Skip to content

Add blog post - react-compound-components - #75

Open
ashwinKumar0505 wants to merge 5 commits into
masterfrom
add-react-compound-components-blog
Open

Add blog post - react-compound-components#75
ashwinKumar0505 wants to merge 5 commits into
masterfrom
add-react-compound-components-blog

Conversation

@ashwinKumar0505

@ashwinKumar0505ashwinKumar0505 commented May 24, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@sanandnarayansanandnarayan self-assigned this May 24, 2021
sanandnarayan
sanandnarayan requested changes May 24, 2021
View reviewed changes
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
1. **Accordion** - The outer wrapper component of the Accordion component. This is the root component of the Accordion component.
2. **AccordionItem** - The component that allows us to define each accordion item. Each AccordionItem will have its AccordionButton and AccordionPanel components.
3. **AccordionButton** - The header for the Accordion component.On clicking the accordion button will open the corresponding accordion panel.
4. **AccordionPanel** - The panel for the accordion. This will hold the content of each accordion item.

@sanandnarayansanandnarayanMay 24, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a diagram?
structure

@sanandnarayansanandnarayanMay 24, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use this tool for the diagram
https://whimsical.com/

@ashwinKumar0505ashwinKumar0505May 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untitled (2)

@ashwinKumar0505ashwinKumar0505May 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to add the image that you had mentioned or shall i add this image?

@sanandnarayansanandnarayanMay 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put more effort into the image

@sanandnarayansanandnarayanMay 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make it like this

Screenshot 2021-05-25 at 1 22 43 PM

@ashwinKumar0505ashwinKumar0505May 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added diagram similar to this. Please check

Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
@sanandnarayan

sanandnarayan commented May 24, 2021

Copy link
Copy Markdown
Member

https://hemingwayapp.com/
use a english grammar checker like grammarly

@sanandnarayan

sanandnarayan commented May 24, 2021

Copy link
Copy Markdown
Member

https://www.loom.com/share/ed237c87494e48a59c708310636eeb10

sanandnarayan
sanandnarayan requested changes May 24, 2021
View reviewed changes
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
Comment threadposts/react-compound-components/2021-5-25-React-compound-compnents.md Outdated
@ashwinKumar0505
ashwinKumar0505force-pushed the add-react-compound-components-blog branch from ebfbffc to ef8c68aCompareMay 25, 2021 06:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanandnarayansanandnarayansanandnarayan requested changes

Assignees

@sanandnarayansanandnarayan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashwinKumar0505@sanandnarayan