Move C3 code to separate class

[marcovtwout]

This PR is a first step in improving #40
Instead of having a copy of c3.php in the project root it can be included from any location.

Basic usage:

require__DIR__ . '/vendor/autoload.php'; // If using Composer//require __DIR__ . '/vendor/codeception/c3/c3.php'; // Or include it directly$c3 = newCodeception\C3(__DIR__); // pass the directory that contains Codeception config files$c3->run();

I only made the minimal changes to test this concept. Best to disable whitespace comparison when reviewing this PR.

There's more to be improved after this:

• Add options to configure error log file and temp output directory
• Make all __c3_-functions part of the class
• Restructure remaining code blocks into functions
  But first I like to get feedback on the current changes and to check if there's any use cases I might have missed.

[Naktibalda]

Please update Setup instructions in README and document how to use c3 with codecept.phar file.

[Naktibalda]

This is a new major version that requires composer, so it would be better to make it depend on Codeception ^5.0 and remove this require block because functions will be loaded by Composer automatically.

Update: If codecept.phar file is used, we have to require codecept.phar/vendor/autoload.php file instead.

[marcovtwout]

Not using Composer autoloader and directly including the file should still work, for example:

require__DIR__ . '/vendor/codeception/c3/c3.php';
$c3 = newCodeception\C3(__DIR__); // pass the directory that contains Codeception config files$c3->run();

[marcovtwout]

Or do you mean that since this will be a new major version of c3, more legacy loading methods can be removed?

Also - I don't know when Codeception v5 will be out, but it's probably better if we can keep support for Codeception v4 as well?

[Naktibalda]

These class aliases were used to support PHPUnit <5.4. They can be removed now.

[Naktibalda]

PHPUnit 5 compatibility

[DavertMik]

Thanks @marcovtwout Looks really nice!

I like the idea but it must be tested very well before releasing. Unfortunately, we have only basic tests on Codeception Ci pipeline.
If we release this as a major version and c3 will be installed only from Composer I think this will be fine for most setups.
Anyway, I need to see that this works and maybe we could release it as beta and ask volunteers to test it.

[marcovtwout]

@DavertMik Thanks for the feedback :)

Here's a preview with some of the improvements I mentioned already applied: https://github.com/marcovtwout/c3/pull/1/commits
And a quick link to the full file: https://github.com/marcovtwout/c3/blob/class_based_c3_improvements/c3.php

Since you are thinking about a new major version anyways, perhaps legacy compatibility parts can be removed as well?

[marcovtwout]

@DavertMik@Naktibalda I revisited this PR after some time has passed. Seems to me this is still a good basis for further improvements.

I created a new PR basing the same changes on the actual version of main: #85