Skip to content

Add modcharting features (using FunkinModchart) - #526

Merged
Raltyro merged 20 commits into
CodenameCrew:mainfrom
dotaxel:modcharting-features
Aug 9, 2025
Merged

Add modcharting features (using FunkinModchart)#526
Raltyro merged 20 commits into
CodenameCrew:mainfrom
dotaxel:modcharting-features

Conversation

@dotaxel

@dotaxeldotaxel commented Jan 8, 2025

Copy link
Copy Markdown

This pull request adds modcharting features using FunkinModchart.
Giving the possibility to create modcharts easily through softcoding (scripts) or hardcoding if preferred.

The tool is based on NotITG and the mirin template, by default you have a large number of modifiers to move and rotate the notes in 3D (instead of just 2D) with correct perspective, set custom paths where the notes will move towards, etc.

As mentioned before, you can move notes along Z and rotate them on all possible axes (X, Y, Z). You can also skew them, bend sustained notes along their path, and much more thanks to the rendering system provided by FunkinModchart!

You can set modifier values, or they can be interpolated using easy functions of your choice, at any point in the song using the Events system.

You can create nodes, add aliases for modifier values, create more playing fields with their own modifiers, and even more!

NOTE: Compilation time can be longer due to FunkinModchart's macros.

Modcharting features can be removed by removing the "MODCHARTING_FEATURES" define from Project.xml.

@Tsaku53

Copy link
Copy Markdown

We need it !

@NexIsDumb

NexIsDumb commented Jan 8, 2025

Copy link
Copy Markdown
Member

sorry to say but this unfortunately doesn't work currently as Codename uses Haxe 4.2.5, even though we've been planning to update soon, as for now this cannot work

i wont close this PR though just yet

@NexIsDumb
NexIsDumb marked this pull request as draft January 8, 2025 20:20
@dotaxel

This comment was marked as low quality.

@dotaxel

This comment was marked as low quality.

@NeeEooNeeEoo added the status:accepted This has been solved successfully label Jan 11, 2025
@dotaxel

This comment was marked as low quality.

@TechnikTil

Copy link
Copy Markdown
Contributor

I'll go do that asap (sorry I'm late)

@TechnikTil

Copy link
Copy Markdown
Contributor

gotta probably do that tmrw

@TechnikTilTechnikTil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)

@dotaxel

This comment was marked as low quality.

@TechnikTil

Copy link
Copy Markdown
Contributor

I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)

There is documentation, it is on the FunkinModchart readme, although I can also add it to the cne wiki if you like.

oh there is??? shit there goes an hour wasted
nah you good, maybe link it when this is merged

@dotaxel

This comment was marked as low quality.

@dotaxel

This comment was marked as low quality.

@RaltyroRaltyro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Codename adapter in the funkin-modchart codebase instead?

@Raltyro
Raltyro requested a review from FuroYTAugust 6, 2025 11:50
@Raltyro

Copy link
Copy Markdown
Member

Furo, since you're fixing something with invisible strumlines crashing, you should do that to funkin-modchart instead of cne repo, it's getting unused, cuz thats for temporary when i forked it

@FuroYT

Copy link
Copy Markdown
Contributor

Furo, since you're fixing something with invisible strumlines crashing, you should do that to funkin-modchart instead of cne repo, it's getting unused, cuz thats for temporary when i forked it

Okay but its going to need a haxelib release but we could still use git for it

@dotaxel

This comment was marked as low quality.

@Raltyro

Copy link
Copy Markdown
Member

Huh then whats the FM_VERSION macro even for

@dotaxel

This comment was marked as low quality.

@dotaxel

This comment was marked as low quality.

@Raltyro
Raltyro merged commit ba50edf into CodenameCrew:mainAug 9, 2025
hackx2 pushed a commit to hackx2/CodenameEngine that referenced this pull request Apr 7, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:acceptedThis has been solved successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dotaxel@Tsaku53@NexIsDumb@TechnikTil@Raltyro@FuroYT@NeeEoo