Skip to content

Update ios to GoogleSignIn 6.0.1 Pod - #136

Merged
reslear merged 13 commits into
CodetrixStudio:masterfrom
justicointeractive:master
Aug 27, 2021
Merged

Update ios to GoogleSignIn 6.0.1 Pod#136
reslear merged 13 commits into
CodetrixStudio:masterfrom
justicointeractive:master

Conversation

@joeflateau

Copy link
Copy Markdown
Contributor

Before v6 you could not run an app using GoogleSignIn on a Simulator on an M1/Apple Silicon Mac.

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

@reslear

Copy link
Copy Markdown
Collaborator

hi @joeflateau wow! cool, this same #133 ?)

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

hi, @reslear yeah i didn't see your PR before but I needed to run an app w/ Google Sign In in a sim on my mac so I did what I needed to do

@reslear

reslear commented Aug 16, 2021

Copy link
Copy Markdown
Collaborator

ok, i'm close my draft :) good job 💪

@reslearreslear mentioned this pull request Aug 16, 2021
7 tasks
Comment threadios/Plugin/Plugin.swift
@reslear

Copy link
Copy Markdown
Collaborator

hi @joeflateau i'm ready to merge pr, but need to fix the 3 warnings, could you do it?

Screenshot 2021-08-24 at 17 20 14

Screenshot 2021-08-24 at 17 20 28

Screenshot 2021-08-24 at 17 20 39

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

@reslear yes I'll do it right now

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

@reslear should be good to go here

@reslear

Copy link
Copy Markdown
Collaborator

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

@reslear what's the management structure for this plugin? are you building a fork or is that just testing and you are maintaining this one now?

@reslear

Copy link
Copy Markdown
Collaborator

@joeflateau this is fork for testing and experiments with open pr, now = origin master + #134 + you #136

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

#134 breaks iOS for me. init can't be used as an identifier like that

@reslear

Copy link
Copy Markdown
Collaborator

temp solution use

func `init`(_ call: CAPPluginCall) {

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

i didn't know you could escape identifiers like that, my solution was: #134 (comment)

@reslear

Copy link
Copy Markdown
Collaborator

How is best solution? (I'm just junior in swift 😃 )

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

I'd use your solution instead, escape with backticks. avoid objc renaming

@reslear

Copy link
Copy Markdown
Collaborator

Could explain why it breaks?

@joeflateau

Copy link
Copy Markdown
ContributorAuthor
 func init(_ call: CAPPluginCall) {
call.unimplemented("Not available on iOS")
}

breaks because init cannot be used as an identifier this way because init is a special method in swift (it's basically a constructor)

however

 func `init`(_ call: CAPPluginCall) {
call.unimplemented("Not available on iOS")
}

works because you've escaped the init method name (https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html)

my solution would also work, but will likely be more painful to maintain than yours

 @objc(init:)
func initSwift(_ call: CAPPluginCall) {
call.unimplemented("Not available on iOS")
}

@reslear

Copy link
Copy Markdown
Collaborator

@joeflateau Now it's clear thanks

@reslear

Copy link
Copy Markdown
Collaborator

@joeflateau What are the test results and which framework used?

@joeflateau

Copy link
Copy Markdown
ContributorAuthor

@reslear no test framework or results for swift, just ran the app and logged in with google

@reslear
reslear merged commit 4859f9c into CodetrixStudio:masterAug 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@joeflateau@reslear