Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 3, 2026. It is now read-only.
Make sure ISON command does not exceed IRC line length limit - #563
Open
tobbi wants to merge 2 commits into
Open
Conversation
tobbi
commented
Aug 12, 2025
ContributorAuthor
I noticed my code is wrong, because of this: |
tobbi
marked this pull request as draft
August 12, 2025 19:18
tobbi
marked this pull request as ready for review
August 12, 2025 20:15
tobbi
commented
Aug 12, 2025
ContributorAuthor
With the last commit we store the nickname list in a class member and wait until the last batch is through before updating the rest of the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the periodical ISON check that happens every 30 seconds can exceed the IRC line limit of 512 bytes easily when there's a lot of open query windows and therefore a lot of nicks. I kept getting error messages from Undernet because of that.
This commit sends the list of nicknames to update in batches.