Skip to content

Opensearch api support - #24

Closed
tomolopolis wants to merge 4 commits into
mainfrom
opensearch-api-support
Closed

Opensearch api support#24
tomolopolis wants to merge 4 commits into
mainfrom
opensearch-api-support

Conversation

@tomolopolis

Copy link
Copy Markdown
Member

This is a minimal set of changes to support OpenSearch in working_with_cogstack.

This ideally needs an integration test with an Elastic and an OpenSearch service

@mart-rmart-r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I'd say.

But this would also need to be implemented for cogstack2.py:
https://github.com/CogStack/working_with_cogstack/blob/main/cogstack2.py

Annoying, I know. But for now, there's 2 different modules for ES/OS stuff.

Furthermore, it would need to be implemented into the cogstac-nlp PR as well:

CogStack/cogstack-nlp#123

@tomolopolis

Copy link
Copy Markdown
MemberAuthor

starting doing this, but then thought are we going to refactor this anyway, and remove the dupe in due course?

@mart-r

Copy link
Copy Markdown
Collaborator

Yeah, fair enough. Just need to make sure this doesn't slip through the cracks!

@tomolopolis

Copy link
Copy Markdown
MemberAuthor

I think I can cancel this, as you've replicated the change to cogstack-nlp

@mart-r

Copy link
Copy Markdown
Collaborator

Yes, that's fair. But I'd leave the branch so we can refer to it if/when needed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomolopolis@mart-r