Skip to content

DRAFT: CC patch - #11

Open
scgbckbone wants to merge 2 commits into
Coldcard:masterfrom
scgbckbone:coldcard-ported
Open

DRAFT: CC patch#11
scgbckbone wants to merge 2 commits into
Coldcard:masterfrom
scgbckbone:coldcard-ported

Conversation

@scgbckbone

Copy link
Copy Markdown
Collaborator

No description provided.

@scgbckbonescgbckbone left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else
{
/* Prapare EP to Receive next packet */
/* Prepare EP to Receive next packet */

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to leave typo

Comment threadports/stm32/main.c
// Hook for a board to run code at start up, for example check if a
// bootloader should be entered instead of the main application.
MICROPY_BOARD_STARTUP();
#endif

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our port should just nop MICROPY_BOARD_STARTUP

Comment threadports/stm32/dma.c

// chip has some special DMA between SDMMC and system
#undef ENABLE_SDIO

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised DMA code in master hasn't caught up to us yet? sure we need this still?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has lots of DMAMUX support (H5/H7/U5/N6 etc.) but no L4+ block at all . So I kept

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@scgbckbone@doc-hex