Skip to content

chore: unify bls - #337

Merged
ltitanb merged 14 commits into
mainfrom
lt/unify-bls
Aug 19, 2025
Merged

chore: unify bls#337
ltitanb merged 14 commits into
mainfrom
lt/unify-bls

Conversation

@ltitanb

@ltitanbltitanb commented Jul 10, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Unifiy BLS signer, signature, and secret key and use the Lighthouse implementation. The main difference is that the bls types actually check that the bytes are valid. Eg before 0x0000... would have been deserialized without a warning, while now deserialization would fail

jclapis
jclapis reviewed Jul 15, 2025
View reviewed changes
Comment threadcrates/common/src/commit/request.rs
Comment threadcrates/common/src/config/mux.rs Outdated
Comment threadcrates/common/src/config/mux.rs Outdated
Comment threadcrates/common/src/config/utils.rs
Comment threadcrates/common/src/pbs/types/mod.rs Outdated
Comment threadcrates/common/src/signer/loader.rs Outdated
Comment threadcrates/common/src/types.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs
Base automatically changed from lt/remove-deneb to mainJuly 16, 2025 19:29
@ltitanb
ltitanb requested a review from jclapisJuly 27, 2025 22:32
jclapis
jclapis previously approved these changes Jul 30, 2025
View reviewed changes
@ltitanb
ltitanb requested a review from jclapisAugust 14, 2025 22:22
@ltitanb
ltitanb merged commit 77a5ac5 into mainAug 19, 2025
2 of 3 checks passed
@ltitanb
ltitanb deleted the lt/unify-bls branch August 19, 2025 19:17
@jclapisjclapis mentioned this pull request Aug 20, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManuelBilbaoManuelBilbaoAwaiting requested review from ManuelBilbao
1 more reviewer
@jclapisjclapisjclapis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltitanb@jclapis