Skip to content

Add nonce and chain ID to signature requests - #354

Merged
ltitanb merged 125 commits into
sigp-audit-fixesfrom
augment-sign-requests
Aug 19, 2025
Merged

Add nonce and chain ID to signature requests#354
ltitanb merged 125 commits into
sigp-audit-fixesfrom
augment-sign-requests

Conversation

@jclapis

Copy link
Copy Markdown
Contributor

This modifies signature requests (and the way signatures are generated) to include an optional nonce that signer modules can use if they want to, and Commit-Boost's chain ID, as part of the signature tree generation. It's a precursor to an update of #297 as a way to make signatures themselves more robust against replays for module developers.

ltitanband others added 30 commits May 13, 2025 17:17
@jclapisjclapis mentioned this pull request Aug 13, 2025
Comment threadcrates/common/src/commit/request.rs Outdated
Base automatically changed from signer-json-api to sigp-audit-fixesAugust 19, 2025 18:41
@jclapis
jclapisforce-pushed the augment-sign-requests branch from 2c70460 to 66913c3CompareAugust 19, 2025 19:06
@ltitanb
ltitanb merged commit 0ef8787 into sigp-audit-fixesAug 19, 2025
1 check passed
@ltitanb
ltitanb deleted the augment-sign-requests branch August 19, 2025 19:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

signerSigner module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jclapis@ManuelBilbao@ltitanb