Skip to content

refactor(signer): Use config-based header to extract IP from - #388

Merged
ManuelBilbao merged 8 commits into
sigp-audit-fixesfrom
trusted_ip_header_config
Oct 21, 2025
Merged

refactor(signer): Use config-based header to extract IP from#388
ManuelBilbao merged 8 commits into
sigp-audit-fixesfrom
trusted_ip_header_config

Conversation

@ManuelBilbao

@ManuelBilbaoManuelBilbao commented Oct 1, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Add a config param to set the trusted HTTP header to get the user's IP from

@ManuelBilbaoManuelBilbao self-assigned this Oct 1, 2025
@ManuelBilbaoManuelBilbao added the signer Signer module label Oct 1, 2025
@ManuelBilbao
ManuelBilbao changed the base branch from main to sigp-audit-fixesOctober 1, 2025 22:12
@ManuelBilbao
ManuelBilbao marked this pull request as ready for review October 2, 2025 13:55
jclapis
jclapis suggested changes Oct 13, 2025
View reviewed changes
Comment threadcrates/signer/src/service.rs Outdated
jclapis
jclapis approved these changes Oct 21, 2025
View reviewed changes

@jclapisjclapis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few documentation amendment suggestions, but they aren't crucial if they're going to block merging.

Comment threadconfig.example.toml
Comment threaddocs/docs/get_started/configuration.md Outdated
Comment threadconfig.example.toml
@ManuelBilbao@jclapis
Apply suggestions from code review
4ce547a
Co-authored-by: Joe Clapis <jclapis@outlook.com>
@ManuelBilbao
ManuelBilbao merged commit e58d67e into sigp-audit-fixesOct 21, 2025
2 checks passed
@ManuelBilbao
ManuelBilbao deleted the trusted_ip_header_config branch October 21, 2025 20:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ltitanbltitanbAwaiting requested review from ltitanb
1 more reviewer
@jclapisjclapisjclapis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ManuelBilbaoManuelBilbao

Labels

signerSigner module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ManuelBilbao@jclapis