Skip to content

Add SSZ types, content negotiation, and encoding helpers - #466

Merged
JasonVranek merged 9 commits into
mainfrom
pr/ssz-core
Jun 1, 2026
Merged

Add SSZ types, content negotiation, and encoding helpers#466
JasonVranek merged 9 commits into
mainfrom
pr/ssz-core

Conversation

@JasonVranek

@JasonVranekJasonVranek commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Introduces the types and helpers needed for SSZ support in the PBS pipeline. No behavior changes, just plumbing the follow-up PRs build on.

What's in this PR

  • EncodingType enum with FromStr/Display, including MIME parameter tolerance (RFC 7231 §3.1.1.1)
  • AcceptedEncodings with q-value-aware Accept header parsing (RFC 9110 §12.5.1)
  • Content-type and consensus-version header helpers
  • SSZ bid value extraction from SignedBuilderBid for all supported forks (Bellatrix through Fulu)
  • deserialize_body and parse_response_encoding_and_fork helpers
  • Per-fork type aliases for BuilderBid and ExecutionPayloadHeader
  • SszValueError, PbsError::GeneralRequest, PbsClientError::DecodeError/RelayError
  • New workspace deps: headers-accept, mediatype
  • Comprehensive unit tests for all new types and helpers

Review notes

Part 1 of 4: SSZ types → get_header → submit_block → validation bypassing

Attribution

This work builds on the SSZ builder flow originally implemented by @eserilev
in #252 and ported to the current codebase by @jclapis in #403.

Co-authored-by: Eitan Seri-Levi eserilev@ucsc.edu
Co-authored-by: Joe Clapis jclapis@outlook.com

@JasonVranek
Add SSZ types, content negotiation, and encoding helpers
e6d68a6
Introduce EncodingType, AcceptedEncodings, and content negotiation
primitives for SSZ support in the PBS pipeline. Includes:
- EncodingType enum with FromStr/Display and MIME param tolerance
- AcceptedEncodings with q-value aware Accept header parsing
- SSZ bid value extraction from SignedBuilderBid by fork
- deserialize_body and parse_response_encoding_and_fork helpers
- Per-fork type aliases for BuilderBid and ExecutionPayloadHeader
- SszValueError, PbsError::GeneralRequest, PbsClientError variants
- Comprehensive unit tests for all new types and helpers
- New deps: headers-accept, mediatype
@JasonVranek
JasonVranek requested a review from a teamMay 20, 2026 00:04
ninaiiad
ninaiiad suggested changes May 20, 2026
View reviewed changes
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/pbs/src/error.rs Outdated
Comment threadcrates/common/src/pbs/error.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
ninaiiad
ninaiiad reviewed May 20, 2026
View reviewed changes
Comment threadcrates/common/src/pbs/error.rs Outdated
ltitanb
ltitanb requested changes May 20, 2026
View reviewed changes
Comment threadcrates/common/src/pbs/types/mod.rs Outdated
Comment threadcrates/common/src/pbs/types/mod.rs
Comment threadcrates/common/src/utils.rs
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/common/src/utils.rs Outdated
Comment threadcrates/pbs/src/error.rs Outdated
Comment threadcrates/common/src/pbs/error.rs Outdated
ninaiiad
ninaiiad reviewed May 21, 2026
View reviewed changes
Comment threadcrates/common/src/ssz.rs Outdated
Comment threadcrates/common/src/wire.rs Outdated
ninaiiad
ninaiiad reviewed May 22, 2026
View reviewed changes
Comment threadcrates/common/src/config/mux.rs Outdated
Comment threadcrates/common/src/config/mux.rs Outdated
Comment threadcrates/common/src/wire.rs Outdated
ManuelBilbao
ManuelBilbao reviewed May 31, 2026
View reviewed changes
Comment threadcrates/common/src/config/mux.rs
Comment threadcrates/pbs/src/mev_boost/register_validator.rs
Comment threadcrates/pbs/src/mev_boost/status.rs
Comment threadcrates/pbs/src/mev_boost/submit_block.rs
@JasonVranek
JasonVranek merged commit b994451 into mainJun 1, 2026
6 checks passed
@JasonVranek
JasonVranek deleted the pr/ssz-core branch June 1, 2026 17:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManuelBilbaoManuelBilbaoManuelBilbao approved these changes
@ltitanbltitanbltitanb approved these changes
+1 more reviewer
@ninaiiadninaiiadninaiiad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JasonVranek@ManuelBilbao@ltitanb@ninaiiad