Skip to content

Rewrite get_header relay communication to support SSZ and JSON - #467

Merged
JasonVranek merged 12 commits into
mainfrom
pr/ssz-routes
Jul 10, 2026
Merged

Rewrite get_header relay communication to support SSZ and JSON#467
JasonVranek merged 12 commits into
mainfrom
pr/ssz-routes

Conversation

@JasonVranek

@JasonVranekJasonVranek commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Rewrites get_header relay communication to support both SSZ and JSON content negotiation.

What's in this PR

  • SSZ and JSON encoding/decoding for relay get_header responses
  • Content-Type and Eth-Consensus-Version header parsing on relay responses
  • Accept header forwarding to relays with q-value ordering
  • MIME parameter tolerance on relay response Content-Type
  • Fork-aware response decoding for all supported forks
  • Updated mock relay and mock validator with SSZ support
  • Dynamic port allocation in tests via get_free_listener (eliminates flaky CI from port collisions)
  • Get_header integration tests covering both encodings
  • Per-fork JSON fixture files for test data

Review notes

The route handler always takes the standard validation path in this PR. Configurable validation modes come in PR 4.

The test infrastructure changes (mock relay SSZ support, dynamic ports) are shared by both get_header and submit_block tests.

Part 2 of 4: SSZ types → get_header → submit_block → validation bypassing

Attribution

This work builds on the SSZ builder flow originally implemented by @eserilev
in #252 and ported to the current codebase by @jclapis in #403.

Co-authored-by: Eitan Seri-Levi eserilev@ucsc.edu
Co-authored-by: Joe Clapis jclapis@outlook.com

Base automatically changed from pr/ssz-core to mainJune 1, 2026 17:26
@JasonVranek
JasonVranek requested a review from a teamJune 1, 2026 17:26
@JasonVranek
JasonVranekforce-pushed the pr/ssz-routes branch 2 times, most recently from c800921 to cbf451dCompareJune 2, 2026 03:30
ninaiiad
ninaiiad reviewed Jun 2, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadtests/src/mock_relay.rs
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/common/src/wire.rs Outdated
Comment threadcrates/common/src/wire.rs
ninaiiad
ninaiiad reviewed Jun 3, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/common/src/wire.rs
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
ManuelBilbao
ManuelBilbao reviewed Jun 9, 2026
View reviewed changes
Comment threadcrates/pbs/src/error.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
@JasonVranek
Add SSZ types, content negotiation, and encoding helpers
517161d
Introduce EncodingType, AcceptedEncodings, and content negotiation
primitives for SSZ support in the PBS pipeline. Includes:
- EncodingType enum with FromStr/Display and MIME param tolerance
- AcceptedEncodings with q-value aware Accept header parsing
- SSZ bid value extraction from SignedBuilderBid by fork
- deserialize_body and parse_response_encoding_and_fork helpers
- Per-fork type aliases for BuilderBid and ExecutionPayloadHeader
- SszValueError, PbsError::GeneralRequest, PbsClientError variants
- Comprehensive unit tests for all new types and helpers
- New deps: headers-accept, mediatype
@JasonVranek
Rewrite get_header relay communication to support SSZ and JSON
f502df3
content negotiation. Includes:
- SSZ and JSON encoding/decoding for relay get_header responses
- Content-Type and Eth-Consensus-Version header parsing
- Accept header forwarding to relays with q-value ordering
- MIME parameter tolerance on relay response Content-Type
- Fork-aware SSZ bid value extraction for all supported forks
- Mock relay and validator SSZ support in test infrastructure
- get_header integration tests for both encodings
- Dynamic port allocation in tests via get_free_listener
@JasonVranek
review fixes
4600217
@JasonVranek
fix order-of-operations bug in send_get_header_impl. Non-success relay
e01b030
responses often carry text/plain; charset=utf-8 Content-Type,
which failed parse_response_encoding_and_fork with "unsupported encoding
type".
@JasonVranek
address review comments
2565c31
ltitanb
ltitanb requested changes Jun 18, 2026
View reviewed changes
Comment threadtests/src/utils.rs Outdated
Comment threadcrates/pbs/src/mev_boost/status.rs
Comment threadcrates/common/src/wire.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header.rs
Comment threadcrates/pbs/src/mev_boost/get_header.rs Outdated
ManuelBilbao
ManuelBilbao reviewed Jun 19, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header.rs
Comment threadcrates/pbs/src/routes/get_header.rs Outdated
@JasonVranek
JasonVranek merged commit e0a9470 into mainJul 10, 2026
6 checks passed
@JasonVranek
JasonVranek deleted the pr/ssz-routes branch July 10, 2026 22:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManuelBilbaoManuelBilbaoManuelBilbao approved these changes
@ltitanbltitanbltitanb approved these changes
+1 more reviewer
@ninaiiadninaiiadninaiiad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JasonVranek@ManuelBilbao@ltitanb@ninaiiad