Skip to content

ws get_header bids stream draft - #483

Merged
ltitanb merged 1 commit into
Commit-Boost:mainfrom
ninaiiad:ng/ws-get-header
Aug 11, 2026
Merged

ws get_header bids stream draft#483
ltitanb merged 1 commit into
Commit-Boost:mainfrom
ninaiiad:ng/ws-get-header

Conversation

@ninaiiad

@ninaiiadninaiiad commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ninaiiad
ninaiiad requested a review from a teamJuly 28, 2026 17:52
ltitanb
ltitanb reviewed Jul 28, 2026
View reviewed changes
Comment threadconfig.example.toml
Comment threadcrates/common/src/pbs/relay.rs Outdated
@JasonVranek

JasonVranek commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

I like the simplicity of per-slot streams vs the old PoC establishing long lived connections. Q is if handshake overhead is neglible or will be problematic / is this enough time for the relay to establish reliable RTTs?

JasonVranek
JasonVranek reviewed Jul 28, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header.rs
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
ltitanb
ltitanb previously approved these changes Aug 3, 2026
View reviewed changes
Comment threadconfig.example.toml Outdated
Comment threadcrates/common/src/pbs/relay.rs Outdated
ltitanb
ltitanb reviewed Aug 3, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs
@ninaiiad
ninaiiadforce-pushed the ng/ws-get-header branch 3 times, most recently from fd8b6a2 to fa466caCompareAugust 3, 2026 19:50
ltitanb
ltitanb previously approved these changes Aug 3, 2026
View reviewed changes
ltitanb
ltitanb previously approved these changes Aug 4, 2026
View reviewed changes
gd-0
gd-0 reviewed Aug 6, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs
JasonVranek
JasonVranek previously approved these changes Aug 10, 2026
View reviewed changes
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs Outdated
Comment threadcrates/pbs/src/mev_boost/get_header_ws.rs
@ltitanb
ltitanb merged commit e622a5e into Commit-Boost:mainAug 11, 2026
3 checks passed
JasonVranek added a commit that referenced this pull request Aug 11, 2026
@JasonVranek
feat(pbs): ePBS builder API + strict Eth-Consensus-Version enforcement
12670f6
Adds the ePBS (gloas) builder-API surface and the strict header rulings,
rebased onto main so it sits on top of the SSZ rewrite (#468) and the
fork-from-slot fix (#487).
ePBS endpoints:
- getExecutionPayloadBid, submitBuilderPreferences, submitSignedBeaconBlock,
with per-builder routing by SignedRequestAuth.data (no Eth-Builder-Url).
- SSZ-first request/response with JSON fallback; the bid poll ladder honors the
proposer's timing headers.
Header discipline (builder-specs #165):
- Eth-Consensus-Version required for JSON and SSZ on the request-auth endpoints;
absent -> MissingVersionHeader, present-but-unsupported -> InvalidVersionHeader,
both 400. The accepted set is Gloas only; any other fork name is a client bug.
- A relay bid whose response fork is not Gloas on the Gloas-only endpoint is a
bad relay response: dropped, never forwarded under the wrong fork.
Status + observability:
- zero addressed builders accepting an ePBS submission maps to 500, not 502
(neither endpoint declares 502); new PbsClientError::NoBuilderResponse.
- decode/accept rejections counted in BEACON_NODE_STATUS via record_client_error;
dropped relay responses in pbs_relay_invalid_response_total{reason,endpoint,relay_id}.
Legacy PBS, the websocket get_header stream (#483), and the #487 fork fix are
unchanged. Suite green, clippy clean.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonVranekJasonVranekJasonVranek approved these changes
@ltitanbltitanbltitanb approved these changes
+2 more reviewers
@vladimir-eavladimir-eavladimir-ea left review comments
@gd-0gd-0gd-0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ninaiiad@JasonVranek@vladimir-ea@gd-0@ltitanb