Skip to content

Fix: Gallery Thumbnails Failing to Re-Assign - #93

Merged
mxmeinhold merged 3 commits into
ComputerScienceHouse:developfrom
jabbate19:consistent-thumbnail
May 17, 2022
Merged

Fix: Gallery Thumbnails Failing to Re-Assign#93
mxmeinhold merged 3 commits into
ComputerScienceHouse:developfrom
jabbate19:consistent-thumbnail

Conversation

@jabbate19

@jabbate19jabbate19 commented Mar 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

So when a file that was the thumbnail of a directory is deleted, the directory doesn't update and causes a 404 when Gallery reaches out to S3/Local Storage to get it again. This makes it detect a non-ok status code and reset the thumbnail for that directory.

Fixes#65
Fixes#67
Fixes#80

mxmeinhold
mxmeinhold reviewed Mar 31, 2022
View reviewed changes
Comment threadgallery/__init__.py
Comment threadgallery/__init__.py Outdated
Comment threadgallery/__init__.py Outdated
@mxmeinhold

mxmeinhold commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Does this really fix 67?

@jabbate19

jabbate19 commented Mar 31, 2022

Copy link
Copy Markdown
ContributorAuthor

There's no need for a UI now. It is automatically checking for broken and knows how to fix itself

@mxmeinhold

mxmeinhold commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Does it update the thumbnail when files get moved? Or only when the thumbnail results in a 404? If it doesn't, then this doesn't resolve 67 nor 65

@jabbate19

jabbate19 commented Mar 31, 2022

Copy link
Copy Markdown
ContributorAuthor

I moved a file in my dev instance and it updated the thumbnail

mxmeinhold
mxmeinhold approved these changes Apr 10, 2022
View reviewed changes

@mxmeinholdmxmeinhold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern, otherwise LGTM

Comment threadgallery/__init__.py
link = "http://" + app.config["SERVER_NAME"] + link
req = requests.get(link)
while req.status_code != requests.codes.ok:
dir_model.thumbnail_uuid = refresh_directory_thumbnail(dir_model)

@mxmeinholdmxmeinholdApr 10, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this default to the "no thumbnail" photo if it fails to generate one? Want to be sure this can't loop infinitely.

@jabbate19jabbate19Apr 10, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@mxmeinhold
mxmeinhold merged commit 4ab26f9 into ComputerScienceHouse:developMay 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxmeinholdmxmeinholdmxmeinhold approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@jabbate19@mxmeinhold