Skip to content

feat: add --ttl flag for NS records in zones create #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomland-94 merged 1 commit into from
Jun 12, 2026
Merged

feat: add --ttl flag for NS records in zones create #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/cmd/zones/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func NewCreateCmd() *cobra.Command {
s := state.FromContext(cmd.Context())

zoneType, _ := cmd.Flags().GetString("type")
ttl, _ := cmd.Flags().GetInt("ttl")

client, err := s.Client()
if err != nil {
Expand All @@ -43,7 +44,7 @@ func NewCreateCmd() *cobra.Command {
Name: args[0],
Type: "NS",
Content: ns,
TTL: 3600,
TTL: ttl,
})
if err != nil {
return fmt.Errorf("failed to create NS record for %s: %w", ns, err)
Expand All @@ -59,6 +60,7 @@ func NewCreateCmd() *cobra.Command {
"name": args[0],
"type": zoneType,
"nameservers": nameservers,
"ttl": ttl,
})
}

Expand All @@ -74,6 +76,7 @@ func NewCreateCmd() *cobra.Command {

cmd.Flags().String("type", "NATIVE", "Zone type. One of: NATIVE|MASTER|SLAVE")
cmd.Flags().StringSlice("nameserver", []string{}, "Nameserver to add (comma-separated or multiple flags)")
cmd.Flags().Int("ttl", 3600, "TTL for the created NS records")
cmd.Flags().StringP("output", "o", "table", "Output format. One of: table|json")
cmd.Flags().BoolP("quiet", "q", false, "Only print the ID of the created zone")
return cmd
Expand Down
Loading