Skip to content

fix(governance): preserve proposal branch create transition - #1176

Open
seonghobae wants to merge 34 commits into
mainfrom
fix/stacked-pr-central-required-workflows
Open

fix(governance): preserve proposal branch create transition#1176
seonghobae wants to merge 34 commits into
mainfrom
fix/stacked-pr-central-required-workflows

Conversation

@seonghobae

@seonghobaeseonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Current protected-main synchronization (2026-08-25)

  • Exact head: 27a686beeefc5fa8d8093021eb835664b78893c1.
  • Protected base: main@8fd471a31399a914d9cb22a840f4a4c68e010ea6.
  • Protected main was merged as a second parent and the branch ref advanced non-force.
  • GitHub merge tree f81b71594bdc7e3dc090669b14f719c99959a300 exactly matched an independent local git merge-tree --write-tree result.
  • The main-relative delta remains exactly the two governance-owner files: scripts/ci/audit_central_required_workflows.py and tests/test_central_required_workflow_ruleset_audit.py.
  • Exact-head local Strix required-workflow smoke and git diff --check pass.
  • Unresolved review threads: 0.
  • Exact-current-head formal approval: absent; the remaining CHANGES_REQUESTED reviews belong to predecessor heads.

Decision: WAIT_FOR_EXACT_HEAD_SECURITY_PROVENANCE_AND_INDEPENDENT_FORMAL_REVIEW.

Buyer-visible gap

ScopeWeave and independent canaries reproduced proposal-branch creation/update failures while organization ruleset 18156473 targeted ~ALL and enforced required workflows during ref creation. That made the normal pull-request transition impossible before the proposal ref could exist.

Refs #1200.

Change

  • require exact default-branch scope: ref_name.include=["~DEFAULT_BRANCH"], ref_name.exclude=[];
  • reject ~ALL, mixed scope, branch globs, string-shaped includes, and exclusions;
  • require workflows.parameters.do_not_enforce_on_create=true;
  • preserve all seven central workflows, exactly two approvals, stale-review dismissal, last-push approval, thread resolution, merge/squash methods, deletion protection, and non-fast-forward protection;
  • keep stacked PRs review-only; final default-branch integration retains the complete ruleset gate.

No consumer source or protected branch was changed.

Test-first evidence

The source-relevant lineage remains:

  • RED: 8 focused failures, including the false pass for ~ALL and missing create-transition validation;
  • GREEN: 20 focused audit tests;
  • full central suite: 1,402 passed, 1 skipped, 16 subtests.

Current hosted evidence

All nine commit-associated workflow runs are terminal GitHub-success: OSV, Secret Scan, SBOM, Scorecard, Security Scan, SAST Semgrep, Python Security, CodeQL, and the intentionally skipped repair workflow.

These labels are not promoted to complete exact-head security evidence:

Live acceptance state

Ruleset 18156473 is active with exact default-branch scope, no exclusions, and do_not_enforce_on_create=true. After reviewed protected-main integration, acceptance still requires a fresh no-bypass ScopeWeave proposal-branch create/update canary and regenerated exact-head #523 evidence.

Do not merge until #1222 supplies authoritative exact-head SAST/Trivy evidence for this unchanged head (or a descendant), all other required evidence remains terminal-passing, and live governance receives the required independent exact-head formal approvals.

Summary by CodeRabbit

  • 버그 수정
    • 중앙 필수 워크플로 규칙이 기본 브랜치에만 정확히 적용되도록 검증을 강화했습니다.
    • 브랜치 생성 시 규칙 우회가 허용되지 않도록 설정 검사를 보완했습니다.
    • 잘못된 포함·제외 범위와 구조적 설정 변경을 더욱 정확하게 감지합니다.

@coderabbitai

coderabbitaiBot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 25a3cb7d-639d-4a81-a779-32a19d9501fe

📝 Walkthrough

Walkthrough

Changes

에이전트 멘션 동시성

Layer / File(s)Summary
인터랙티브 동시성 계약
.github/workflows/agent-mention-*.yml, docs/doctoring/agent-mention-concurrency-isolation.md, tests/test_agent_mention_*, CHANGELOG.md
인터랙티브 에이전트 멘션에서 로컬 concurrency와 지원되지 않는 queue: max를 제거했습니다. 예약 sweep은 취소하지 않는 별도 동시성 그룹을 유지합니다. 관련 문서와 테스트를 갱신했습니다.

중앙 required-workflow 적용 범위

Layer / File(s)Summary
규칙셋 범위와 감사 검증
scripts/ci/audit_central_required_workflows.py, tests/test_central_required_workflow_ruleset_audit.py, docs/org-required-workflow-rollout.md, docs/adr/0001-central-review-stacked-pull-requests.md, README.md
중앙 규칙셋의 대상 범위를 ~DEFAULT_BRANCH에서 ~ALL로 변경했습니다. stacked pull request의 base branch 적용 내용을 문서화하고, 감사 스크립트와 회귀 테스트를 갱신했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:🟡 Moderate · up to c18d8

This PR expands central governance reviews to stacked branches, but its validation currently permits malformed branch-scope configurations that could allow required review coverage to be missed without detection. The audit contract and regression tests should be tightened before merging.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 63.64% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files. (5 skipped: 5 unsupported.)Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check⚠️ Warning제목은 제안 브랜치 생성 전환을 설명하지만, 변경사항의 핵심인 스택형 PR 거버넌스와 중앙 규칙셋 범위 변경을 반영하지 않습니다.스택형 PR에 중앙 필수 워크플로를 적용하고 규칙셋 범위를 모든 브랜치로 확장한 변경을 제목에 명시하십시오.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stacked-pr-central-required-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integrationdevin-ai-integrationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Current-head validation at c11fb657e1a71fabd8cdbf06d1e6a821163bd836:

  • live CWL Central required workflows ruleset 18156473: active, repository_name.include=["~ALL"], ref_name.include=["~ALL"], seven central workflows, two approving reviews; audit script: PASS;
  • tests/test_central_required_workflow_ruleset_audit.py: 16 passed;
  • audit module: 130 statements / 66 branches, 100% coverage;
  • interrogate 100%, compileall, and git diff --check passed.

The full central suite had prior 100% evidence on the unchanged main source; this PR adds only the scoped audit/docs/ADR/test contract. Hosted current-head Checks and two qualifying independent approvals remain required; no bypass or self-approval.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Successor current-head validation at ab65fcc7dd6547e84cca8a699430d06077dad022:

  • live ruleset 18156473: active, repository_name.include=["~ALL"], ref_name.include=["~ALL"], seven central workflows, two approving reviews; audit script: PASS;
  • focused audit tests: 16 passed; audit module coverage 100%; interrogate 100%; compileall and git diff --check passed.

The documentation-only successor preserves the implementation proof; stale predecessor-head review evidence does not count. A fresh exact-head independent review and current hosted Checks remain required before merge.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Exact current head is now bc2c93ac88599837555cb1ff3292bb49d245dc5a after the ledger timestamp refresh. Focused audit proof remains unchanged; hosted required Checks and fresh exact-head review must be evaluated on this successor.

@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 18:35
@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Current-head validation for bc2c93a: verified the live organization ruleset 18156473 is active with ref_name.include=[~ALL], and the PR aligns the audit code, regression fixture, ADR, and operator rollout ledger with stacked pull-request coverage. Passed: 16 central ruleset audit tests, Ruff, compileall, and git diff --check. Please review this exact head; merge remains gated on an independent non-author approval and terminal protected checks.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent Please review the current PR head bc2c93a. Verify the live ruleset alignment, stacked-PR scope audit, changed-file evidence, current mergeability, and required checks. Do not approve a stale head.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent review exact current HEAD bc2c93a. Inspect the complete diff, validate security and regression behavior, and publish only evidence bound to this SHA. Do not transfer predecessor approval, modify the branch, or merge.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent please review exact current HEAD bc2c93ac88599837555cb1ff3292bb49d245dc5a against main; verify stacked-branch required-workflow scope, live ruleset audit, and protection invariants.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@cwl-noema-review please independently review exact current HEAD bc2c93ac88599837555cb1ff3292bb49d245dc5a against main; verify the all-branch ruleset audit and central workflow/protection invariants.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Reproduced and fixed the central router Check failure at exact HEAD 501fe541b725f611145d42672c66b3411287d36d: repository_dispatch was using a job token with actions: read, and the local concurrency block contained unsupported queue: max. The local router now has actions: write, valid native concurrency, and regression coverage. Tests: 8 passed; full actionlint and diff check pass. @opencode-agent please re-review this exact HEAD.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@cwl-noema-review independently re-review exact current HEAD 501fe541b725f611145d42672c66b3411287d36d against main; verify repository-dispatch permission, actionlint-valid concurrency, and central stacked-PR governance.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Exact-head causal repair evidence for aa63517844476ad5d5cfac37f6126d640d5d5115:

  • Current-head root cause: deleting unsupported concurrency.queue while retaining the local concurrency group permits only one pending run; a later trusted mention can replace an earlier pending mention before its durable claim exists. The same commit also expanded local Actions permission from read to write even though repository dispatch is authorized by the existing contents: write scope and artifact access is read-only.
  • RED: four focused contract failures reproduced the replacing local queue and unused actions: write grant.
  • Narrow fix: remove the local route's concurrency group entirely, preserve the scheduled sweep's separate single-flight group, restore actions: read, and converge the doctoring/changelog contract on GitHub's supported one-running/one-pending semantics.
  • Focused GREEN: 8 passed.
  • Full GREEN: 1,235 passed plus 16 subtests.
  • compileall and git diff --check pass.
  • All six exact GitHub blobs match the locally verified files.

Hosted exact-head workflows and independent formal review remain separate non-passing gates until terminal evidence exists.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Current-head validation for aa63517844476ad5d5cfac37f6126d640d5d5115: 27 focused agent-mention/ruleset tests passed; actionlint passed for .github/workflows/agent-mention-router.yml; compileall and git diff --check passed. The PR scope remains governance-only, with Figma File ID N/A. Review this exact head against the protected ruleset before merge.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent review\nHead SHA: aa63517\nReview current HEAD only; check ruleset scope, stacked-PR required workflows, workflow permissions, and all changed tests/docs. Re-run after any push.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Current-head validation for aa63517844476ad5d5cfac37f6126d640d5d5115: 24 focused governance/router tests passed; actionlint passed for .github/workflows/agent-mention-router.yml; compileall and git diff --check passed. The least-privilege route keeps Contents write for repository dispatch and Actions read for artifact reads; no Figma UI contract applies (Figma File ID: N/A).

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent review\nHead SHA: aa63517\nReview this exact head only, including least-privilege permissions, repository-dispatch authorization, and all changed queue/idempotency contracts. Re-run after any push.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Exact-head verification for the stacked central workflow governance change.

Current pushed head: a7aeb5683b25d1f82fb4ac2f72685391f3bccf62

Root cause fixed: GitHub Actions rejects the unsupported concurrency.queue key in both agent-mention-noema-dispatch.yml and agent-mention-opencode-dispatch.yml, preventing the downstream dispatch workflows from starting. Removed only that key; exact invocation-key groups and cancel-in-progress: false remain unchanged. Updated the existing contract test to reject the unsupported key.

Verified at this exact head:

  • RED: the updated contract test failed on the predecessor because both wrappers contained queue: max.
  • uv run pytest -q tests/test_agent_mention_downstream_idempotency.py: 4 passed after the fix.
  • uv run pytest -q tests/test_agent_mention_*.py: 84 passed.
  • uv run coverage run -m pytest -q: 1235 passed, 16 subtests passed.
  • coverage report: 100% statement and branch coverage; interrogate: 100%.
  • actionlint on both downstream workflows, compileall, and git diff --check: passed.

@opencode-agent please perform the independent formal review for current head a7aeb5683b25d1f82fb4ac2f72685391f3bccf62. Review-only request: do not merge or enable auto-merge.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Correction to the previous evidence comment: the exact pushed/current PR head is a7aeb56804c043b97f837a82d9066dfc03eec938. The verification results and requested review apply to this exact head. @opencode-agent please review this SHA independently; do not merge or enable auto-merge.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Queued @opencode-agent for PR #1176 at head c18d8c03f6b7c09253e4f89b0741f24fdcfe96f2. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Queued @cwl-noema-review for PR #1176 at head c18d8c03f6b7c09253e4f89b0741f24fdcfe96f2. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

@coderabbitai

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ef62a253-ff9a-443a-a24f-adbfda3e12ea

📥 Commits

Reviewing files that changed from the base of the PR and between c18d8c0 and 36d4fec.

📒 Files selected for processing (2)
  • scripts/ci/audit_central_required_workflows.py
  • tests/test_central_required_workflow_ruleset_audit.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

중앙 required-workflow 규칙셋 감사가 기본 브랜치 전용 ref 범위와 비어 있는 제외 목록을 확인합니다. 워크플로 규칙의 do_not_enforce_on_create 매개변수도 검증합니다. 관련 회귀 테스트는 허용되지 않는 범위와 드리프트 오류를 확인합니다.

Changes

중앙 required-workflow 감사 검증

Layer / File(s)Summary
규칙셋 감사 검증
scripts/ci/audit_central_required_workflows.py
ref 범위가 ~DEFAULT_BRANCH만 포함하고 제외 목록이 비어 있는지 확인합니다. 단일 워크플로 규칙의 do_not_enforce_on_createTrue인지 확인합니다.
감사 회귀 테스트
tests/test_central_required_workflow_ruleset_audit.py
기본 브랜치 전용 범위를 벗어나는 include, exclude 및 문자열 include를 거부합니다. 브랜치 생성 전환 오류와 중복 규칙 처리를 검증합니다. 구조적 드리프트 오류 메시지를 갱신합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk:🟡 Moderate · up to 36d4f

The change is intended to restore proposal-branch creation without weakening protected-main governance, but it is not merge-ready because authoritative security results for the exact commit and required independent approvals are still missing.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 4 files.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ Passed제목은 중앙 거버넌스 규칙셋의 proposal branch 생성 전환을 수정하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stacked-pr-central-required-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Fresh ScopeWeave consumer-path refetch found the central owner repair itself needs stack reconciliation before it can unblock leaf writes. Exact current central state: protected main@9fd60f2c8c33f11a030fe7528adb1e686a993fb1; PR #1176 head 5b2a2163eead22ffe0a65708cd4136e51afe291a; merge base 4c33442021d63b09f35a874c5e7a779dd46ef8f2; GitHub comparison is diverged, ahead 22 / behind 14, and PR metadata currently reports mergeable=false. Please reconcile the existing #1176 branch non-destructively with the exact live main tip, preserve the already-proven #1200 ruleset/create-transition RED→GREEN contract and any unique intervening main fixes, then regenerate exact-current-head central tests/coverage/security/reviews. Do not weaken the seven required workflows, two-review/last-push/thread/deletion/non-fast-forward protections, or create a parallel owner PR. After protected integration, ScopeWeave will rerun the normal proposal-branch/update canary and then continue #523's repository-owned exact-head Dependency Review repair.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent please perform a fresh formal review of exact head 49f6988795262194e4eda8b3ea7319b7b39c4e77 against protected base 885f2cd251999f21cf562cab3e2d9cc3cc3ec737. This non-forced merge reconciliation preserves current main exactly and retains only the #1200 owner paths: the strict default-branch ref-scope/create-transition audit and its deterministic regressions. The current PR diff is exactly two files, unresolved threads are zero, mergeability is restored, and every materialized exact-head PR workflow is terminal success. Please run the current-head coverage suite and publish the substantive Reviews API verdict; do not reuse predecessor review evidence.

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 49f6988795262194e4eda8b3ea7319b7b39c4e77.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["CI script: audit_central_required_workflows.py"]
S1 --> I1["review and security gate shell path"]
I1 --> R1["Review risk: CI script: audit_central_required_workflows.py"]
R1 --> V1["bash -n plus Strix self-test"]
Evidence --> S2["Test: test_central_required_workflow_ruleset_audit.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_central_required_workflow_ruleset_audit.py"]
R2 --> V2["targeted test run"]
Loading

@opencode-agent

opencode-agentBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 27a686beeefc5fa8d8093021eb835664b78893c1
  • Workflow run: 32825666061
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 27a686beeefc5fa8d8093021eb835664b78893c1.

  • Head SHA: 27a686beeefc5fa8d8093021eb835664b78893c1

  • Workflow run: 32825666061

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["CI script: audit_central_required_workflows.py"]
S1 --> I1["review and security gate shell path"]
I1 --> R1["Review risk: CI script: audit_central_required_workflows.py"]
R1 --> V1["bash -n plus Strix self-test"]
Evidence --> S2["Test: test_central_required_workflow_ruleset_audit.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_central_required_workflow_ruleset_audit.py"]
R2 --> V2["targeted test run"]
Loading

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 49f6988795262194e4eda8b3ea7319b7b39c4e77.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["CI script: audit_central_required_workflows.py"]
S1 --> I1["review and security gate shell path"]
I1 --> R1["Review risk: CI script: audit_central_required_workflows.py"]
R1 --> V1["bash -n plus Strix self-test"]
Evidence --> S2["Test: test_central_required_workflow_ruleset_audit.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_central_required_workflow_ruleset_audit.py"]
R2 --> V2["targeted test run"]
Loading

Merge protected main non-destructively while retaining only the create-transition audit and its executable regressions. Focused ruleset audit: 20 passed. Full suite: 1,402 passed, 1 skipped, 16 subtests.
Preserve only the two governance owner files over protected main 0c6b9a6. Focused ruleset audit: 20 passed. Full suite: 1,402 passed, 1 skipped, 16 subtests.
@seonghobae

Copy link
Copy Markdown
ContributorAuthor

Exact-head check RCA: Strix run 32691651686 produced no vulnerability report artifact and failed after the configured fallback returned HTTP 404. The gate correctly treats this as provider/backend infrastructure, not a source finding. Revalidate after provider remediation; do not weaken the security gate.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent review

Please submit a substantive formal Reviews API verdict for exact current head cc941b2afc36dbe84f829051547a41459769d579 against protected main@0c6b9a6459c9dbdf5e23fb01df7a32a8a14964b3. All substantive commit-associated workflows are terminal success, unresolved review threads are 0, and no qualifying exact-head formal verdict exists. Review the current default-branch ruleset scope and create-transition audit contract only; predecessor reviews and status/check success are non-passing substitutes. Review-only: do not mutate or merge the branch.

@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 06:44
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

@opencode-agent review

Please publish an independent substantive formal Reviews API verdict for exact current head 55a6a796d453ca4718859889fbbd4b416c20ebf1 against protected main@613a33e0cb1c6db9790fae99f6253445712ac37a. All 8 substantive exact-head workflows are terminal-success and unresolved review threads are 0. Older CHANGES_REQUESTED, COMMENTED, check/status, and predecessor-head evidence is historical. Inspect the complete current diff and bind APPROVED or CHANGES_REQUESTED only to this SHA; do not reuse an older verdict.

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 55a6a796d453ca4718859889fbbd4b416c20ebf1.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["CI script: audit_central_required_workflows.py"]
S1 --> I1["review and security gate shell path"]
I1 --> R1["Review risk: CI script: audit_central_required_workflows.py"]
R1 --> V1["bash -n plus Strix self-test"]
Evidence --> S2["Test: test_central_required_workflow_ruleset_audit.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_central_required_workflow_ruleset_audit.py"]
R2 --> V2["targeted test run"]
Loading

@opencode-agent
opencode-agentBot disabled auto-merge August 24, 2026 16:44
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Owner-path refresh for the ScopeWeave #523 governance dependency: current PR head is 27a686beeefc5fa8d8093021eb835664b78893c1 against protected main@8fd471a31399a914d9cb22a840f4a4c68e010ea6. The current-head OSV, Secret Scan, SBOM, Scorecard, Security Scan, SAST Semgrep, Python Security, and CodeQL runs are now terminal success; the remaining OpenCode CHANGES_REQUESTED reviews are bound to predecessor heads and must not be transferred. @opencode-agent please review this exact current head only and replace stale predecessor evidence with a current-head formal decision. @cwl-noema-review please independently review this exact current head only. Preserve the existing ruleset/review gates; do not merge or mutate source from this request.

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 27a686beeefc5fa8d8093021eb835664b78893c1.

  • Head SHA: 27a686beeefc5fa8d8093021eb835664b78893c1

  • Workflow run: 32825666061

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["CI script: audit_central_required_workflows.py"]
S1 --> I1["review and security gate shell path"]
I1 --> R1["Review risk: CI script: audit_central_required_workflows.py"]
R1 --> V1["bash -n plus Strix self-test"]
Evidence --> S2["Test: test_central_required_workflow_ruleset_audit.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_central_required_workflow_ruleset_audit.py"]
R2 --> V2["targeted test run"]
Loading

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
ContributorAuthor

Protected-main convergence and exact-tree verification (2026-08-26)

  • Exact head: 366fe2f7955ba5d6a667b748b9ef28d3cde51949.
  • Protected base fetched immediately before publication: main@33dc57d7984b937e4f5ab915d5eae69a0f42e3a5.
  • The branch ref advanced non-force to a two-parent commit: prior owner head 27a686beeefc5fa8d8093021eb835664b78893c1 plus protected main.
  • GitHub-created tree 9b5fcc26233b0d977402c879f233f9eacb353fc3 exactly matches the independently constructed local merge tree.
  • The main-relative owner delta remains exactly scripts/ci/audit_central_required_workflows.py and tests/test_central_required_workflow_ruleset_audit.py.
  • Focused governance audit: 20 passed.
  • Full central suite: 1,442 passed, 1 skipped, 16 subtests.
  • Full Strix quick gate: PASS.
  • git diff --check: PASS.
  • Unresolved review threads: 0.
  • Exact-current-head formal approvals: 0.

The new exact-head hosted workflows are queued; queued/skipped evidence is non-passing. The live organization-ruleset payload could not be freshly fetched through the available connector in this invocation, so prior live scope evidence is not promoted to a fresh acceptance claim. Acceptance still requires terminal exact-head evidence, independent current-head formal review, protected-main integration, and a no-bypass ScopeWeave proposal-branch create/update canary. No consumer source or refs were changed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: mediumNormal-priority or P2 workscope: product-gapCustomer-visible product gapstatus: blockedBlocked by conflict, dependency, or required prerequisitetype: bugDefect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae