Uh oh!
There was an error while loading. Please reload this page.
fix(opencode): honor exact Corepack pnpm specs - #1230
Merged
Conversation
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
LineageWeave PRs #405 and #387 declare an exact Corepack-compatible
packageManagervalue with an integrity suffix. The trusted materializer accepted that value, but the OpenCode image admitted only one hard-coded pnpm version and rejected the already-validated exact spec before repository tests could start.The central workflow reuses the native Corepack implementation already bundled with the pinned Node runtime. It prepares the exact materialized spec in the trusted image layer, keeps the cache root-owned and read-only at runtime, and invokes pnpm through Corepack. No second package-manager source or floating version is introduced.
Exact-head verification
46c061095b0569d86303408610e238298d1963519fd60f2c8c33f11a030fe7528adb1e686a993fb11,371 passed, 1 skipped100%(8,340statements /3,214branches)100%75 passedPASSStandards and security
The implementation follows the exact package-manager contract documented by Node.js packageManager and the Corepack project. Trusted-spec validation, disabled lifecycle scripts, networkless runtime execution, and the existing PR-head trust boundary remain unchanged.
Detailed APA 7 references and RCA are in
docs/doctoring/opencode-exact-pnpm-corepack-runtime.md.