Skip to content

Fix OpenCode review publish failures - #176

Merged
opencode-agent[bot] merged 16 commits into
mainfrom
codex/fix-opencode-review-publish-failure
Jun 30, 2026
Merged

Fix OpenCode review publish failures#176
opencode-agent[bot] merged 16 commits into
mainfrom
codex/fix-opencode-review-publish-failure

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • fail the OpenCode approval gate when the PR review POST cannot publish
  • keep the review overview best-effort, but do not leave a green OpenCode check without an APPROVE/REQUEST_CHANGES review side effect
  • add a static regression assertion for the explicit failure path

Verification

  • git diff --check
  • local full bash test attempted, but this Windows checkout has CRLF line endings that make bash reject sourced helper scripts before the edited assertions run

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model attempts did not emit a usable current-head control block, but the deterministic approval fallback verified this is a no-diff or central review-process-only change with same-head peer checks green.

Findings

No blocking findings.

Changed-file evidence

  • .github/workflows/opencode-review.yml
  • scripts/ci/test_strix_quick_gate.sh

Summary

Reviewed the bounded no-diff or central review process change list and peer GitHub Checks for current head 114298a8a79fe366538d9834a4fcda17a2581a65. This fallback is limited to no-diff PR heads or the central OpenCode/Strix workflow and CI-gate files, after coverage evidence succeeded, peer checks completed without failures, mergeability was checked, and unresolved human review threads were absent.

Verification posture: Linter/static: peer GitHub Checks completed without source-backed failures before fallback approval. TDD/regression: central CI gate tests are part of the changed review-process files and peer checks completed. Coverage: Coverage execution evidence job result was success and completed before approval. Docstring coverage: Coverage evidence handled configured docstring gates or advisory status. DAG: Change Flow DAG maps central review workflow/script changes to required review checks and fallback approval path. PoC/execution: peer GitHub Checks and coverage evidence were re-queried for this exact head before approval. DDD/domain: no product domain code is in the fallback allowlist. CDD/context: structural scope is restricted to the central review process files listed above. Similar issues: repeated OPENCODE_REVIEW_UNAVAILABLE outcomes for this head motivated this fallback path. Claim/concept check: no PR metadata claims were accepted beyond GitHub diff and check APIs. Standards search: not applicable for this process-only fallback. Compatibility/convention: fallback reuses existing create_pull_review, check, mergeability, and human-thread gates. Breaking-change/backcompat: limited to central review workflow behavior. Performance: no runtime product path changed. Developer experience: maintainers get a review-state outcome instead of a silent tooling-stability dead end. User experience: PR readers get an explicit approval reason and changed-file evidence. Security/privacy: approval token and pull_request_target review boundaries remain unchanged.

  • Result: APPROVE
  • Reason: no-diff or central review-process-only fallback after repeated unusable OpenCode model output and green same-head peer evidence.
  • Head SHA: 114298a8a79fe366538d9834a4fcda17a2581a65
  • Workflow run: 28416834864
  • Workflow attempt: 1

Change Flow DAG

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["CI script: test_strix_quick_gate.sh"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: test_strix_quick_gate.sh"]
R2 --> V2["bash -n plus Strix self-test"]
Loading

@opencode-agent

opencode-agentBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: d8b9745f5026dd79ecc2ecf7a15edc0913b82490
  • Workflow run: 28418818163
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode model attempts did not emit a usable current-head control block, but the deterministic approval fallback verified this is a no-diff or central review-process-only change with same-head peer checks green.

Findings

No blocking findings.

Changed-file evidence

  • .github/workflows/opencode-review.yml
  • scripts/ci/test_strix_quick_gate.sh

Summary

Reviewed the bounded no-diff or central review process change list and peer GitHub Checks for current head d8b9745f5026dd79ecc2ecf7a15edc0913b82490. This fallback is limited to no-diff PR heads or the central OpenCode/Strix workflow and CI-gate files, after coverage evidence succeeded, peer checks completed without failures, mergeability was checked, and unresolved human review threads were absent.

Verification posture: Linter/static: peer GitHub Checks completed without source-backed failures before fallback approval. TDD/regression: central CI gate tests are part of the changed review-process files and peer checks completed. Coverage: Coverage execution evidence job result was success and completed before approval. Docstring coverage: Coverage evidence handled configured docstring gates or advisory status. DAG: Change Flow DAG maps central review workflow/script changes to required review checks and fallback approval path. PoC/execution: peer GitHub Checks and coverage evidence were re-queried for this exact head before approval. DDD/domain: no product domain code is in the fallback allowlist. CDD/context: structural scope is restricted to the central review process files listed above. Similar issues: repeated OPENCODE_REVIEW_UNAVAILABLE outcomes for this head motivated this fallback path. Claim/concept check: no PR metadata claims were accepted beyond GitHub diff and check APIs. Standards search: not applicable for this process-only fallback. Compatibility/convention: fallback reuses existing create_pull_review, check, mergeability, and human-thread gates. Breaking-change/backcompat: limited to central review workflow behavior. Performance: no runtime product path changed. Developer experience: maintainers get a review-state outcome instead of a silent tooling-stability dead end. User experience: PR readers get an explicit approval reason and changed-file evidence. Security/privacy: approval token and pull_request_target review boundaries remain unchanged.

  • Result: APPROVE
  • Reason: no-diff or central review-process-only fallback after repeated unusable OpenCode model output and green same-head peer evidence.
  • Head SHA: d8b9745f5026dd79ecc2ecf7a15edc0913b82490
  • Workflow run: 28418818163
  • Workflow attempt: 1

Change Flow DAG

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["CI script: test_strix_quick_gate.sh"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: test_strix_quick_gate.sh"]
R2 --> V2["bash -n plus Strix self-test"]
Loading

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model attempts did not emit a usable current-head control block, but the deterministic approval fallback verified this is a no-diff or central review-process-only change with same-head peer checks green.

Findings

No blocking findings.

Changed-file evidence

  • .github/workflows/opencode-review.yml
  • scripts/ci/test_strix_quick_gate.sh

Summary

Reviewed the bounded no-diff or central review process change list and peer GitHub Checks for current head 9683d2d798ba275f559308aa89992fbf8c4116a1. This fallback is limited to no-diff PR heads or the central OpenCode/Strix workflow and CI-gate files, after coverage evidence succeeded, peer checks completed without failures, mergeability was checked, and unresolved human review threads were absent.

Verification posture: Linter/static: peer GitHub Checks completed without source-backed failures before fallback approval. TDD/regression: central CI gate tests are part of the changed review-process files and peer checks completed. Coverage: Coverage execution evidence job result was success and completed before approval. Docstring coverage: Coverage evidence handled configured docstring gates or advisory status. DAG: Change Flow DAG maps central review workflow/script changes to required review checks and fallback approval path. PoC/execution: peer GitHub Checks and coverage evidence were re-queried for this exact head before approval. DDD/domain: no product domain code is in the fallback allowlist. CDD/context: structural scope is restricted to the central review process files listed above. Similar issues: repeated OPENCODE_REVIEW_UNAVAILABLE outcomes for this head motivated this fallback path. Claim/concept check: no PR metadata claims were accepted beyond GitHub diff and check APIs. Standards search: not applicable for this process-only fallback. Compatibility/convention: fallback reuses existing create_pull_review, check, mergeability, and human-thread gates. Breaking-change/backcompat: limited to central review workflow behavior. Performance: no runtime product path changed. Developer experience: maintainers get a review-state outcome instead of a silent tooling-stability dead end. User experience: PR readers get an explicit approval reason and changed-file evidence. Security/privacy: approval token and pull_request_target review boundaries remain unchanged.

  • Result: APPROVE
  • Reason: no-diff or central review-process-only fallback after repeated unusable OpenCode model output and green same-head peer evidence.
  • Head SHA: 9683d2d798ba275f559308aa89992fbf8c4116a1
  • Workflow run: 28417495810
  • Workflow attempt: 1

Change Flow DAG

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["CI script: test_strix_quick_gate.sh"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: test_strix_quick_gate.sh"]
R2 --> V2["bash -n plus Strix self-test"]
Loading

@opencode-agent
opencode-agentBot enabled auto-merge (squash) June 30, 2026 03:24
@opencode-agent
opencode-agentBot merged commit f5bae9a into mainJun 30, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae