Uh oh!
There was an error while loading. Please reload this page.
Tighten OpenCode mapped-output regression review - #269
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the shared review rubrics to more explicitly catch regressions when placeholder/best-effort outputs are replaced with concrete mapped values, by requiring reviewers to trace mapping producers and validate fallback/legacy paths.
Changes:
- Adds a mapped-output regression review rule to the OpenCode reviewer prompt.
- Adds a stricter mapped-output regression review rule to the CI reviewer prompt (including “block approval” guidance).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| code-reviewer-prompt.md | Adds a new rubric item prompting reviewers to trace mapping producers/fallbacks and expect coverage for mapped-output changes. |
| ci-review-prompt.md | Adds a new CI rubric item to review mapping producers/fallbacks and block approval on silent-drop/regression risks, with test requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head bounded evidence and found no blocking issues. FindingsNo blocking findings. SummaryApproval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
- Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.
Review thread evidence
Latest unresolved reviewer thread evidence
code-reviewer-prompt.md line 132
- Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T06:07:44Z
- Comment URL: #269 (comment)
- Comment excerpt: The phrase "replaces placeholder, inferred, or best-effort generated output" is grammatically ambiguous (placeholder/inferred are adjectives without a noun) and "best-effort generated" should be hyphenated as a compound modifier. Consider naming the kind of output explicitly for clarity.
code-reviewer-prompt.md line 136
- Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T06:07:45Z
- Comment URL: #269 (comment)
- Comment excerpt: This section says "expect tests", but the PR intent is to require reviewers to call out missing coverage for concrete mappings and fallback paths. Using "require" (and clarifying when fallback/composite tests are needed) makes the rubric unambiguous and consistent with the stricter CI rubric.
ci-review-prompt.md line 118
- Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T06:07:45Z
- Comment URL: #269 (comment)
- Comment excerpt: Same as in code-reviewer-prompt.md: "placeholder, inferred, or best-effort generated output" is ambiguous and "best-effort generated" should be hyphenated. Also, aligning on "trace" here better matches the stated goal of verifying producers/fallbacks rather than doing a generic review.
ci-review-prompt.md line 121
Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T06:07:45Z
Comment URL: #269 (comment)
Comment excerpt: "regress from the previous output" reads awkwardly; "regress compared to" (or similar) is clearer and avoids implying a directional change away from output. Rewrapping slightly also keeps the sentence readable.
Result: REQUEST_CHANGES
Reason: unresolved reviewer or review-agent thread(s) were present before approval.
Head SHA:
db464f8403ffda716f479e4d6b4aa6204ec3a6b2Workflow run: 28497230522
Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including ci-review-prompt.md, code-reviewer-prompt.md.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects ci-review-prompt.md to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: Valid improvements to mapped-output review guidance
- Head SHA:
d271f448f09a752e620fa954ef9ed85cda0e8841 - Workflow run: 28498198603
- Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Addressed by d271f44 and superseded by current-head OpenCode approval.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Why
Copilot caught FK DDL export regressions on pg-erd-cloud #404 that OpenCode initially approved. This tightens the central review rubric instead of adding a repository-specific workaround.