[codex] Restore long OpenCode review budget

[seonghobae]

[Copilot is generating a summary...]

[Copilot]

Pull request overview

This PR restores a longer OpenCode review execution budget by increasing GitHub Actions timeouts and aligning contract/regression tests with the updated workflow configuration.

Changes:

• Increase opencode-review-target job and model-pool step timeouts in .github/workflows/opencode-review.yml.
• Increase OpenCode run/retry budget environment variables to 5 hours.
• Update workflow contract assertions in tests/ and Strix quick-gate regression expectations in scripts/ci/.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/test_opencode_agent_contract.py	Updates workflow contract assertions for the new timeout values.
scripts/ci/test_strix_quick_gate.sh	Updates Strix quick-gate assertions/messages to expect the restored long OpenCode budgets.
.github/workflows/opencode-review.yml	Increases job/step timeouts and OpenCode run/retry budget env vars for the review workflow.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Pull request overview

OpenCode exhausted the configured model pool without a usable current-head review conclusion. This is not approval evidence, so the PR is blocked until a source-backed review can establish approval sufficiency or identify concrete fixes.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - OpenCode could not establish approval sufficiency

• Problem: every configured model path failed to produce a usable current-head control block.
• Root cause: model execution, timeout, export, normalization, or approval-gate validation did not complete after exponential retry across the configured model pool.
• Impact: approving from deterministic check state alone would miss PR-intent mismatches, missing files, edge-case bugs, robustness gaps, UX/DX regressions, security issues, and CodeGraph-backed base/head flow changes.
• Fix: rerun OpenCode after model availability recovers, or update the PR with the missing files, tests, docs, generated artifacts, and verification evidence needed for a source-backed review conclusion.
• Regression test: keep the approval gate posting REQUEST_CHANGES, not APPROVE or check-only failure, when no model produces a valid current-head review.

Summary

• Result: REQUEST_CHANGES
• Reason: coverage-evidence passed and peer GitHub Checks completed without failures, but no model produced a valid review control block.
• Deterministic evidence checked but not used for approval: current-head changed-file evidence (.github/workflows/opencode-review.yml, scripts/ci/test_strix_quick_gate.sh, tests/test_opencode_agent_contract.py); coverage-evidence result success; peer checks from statusCheckRollup excluding this OpenCode check.
• Model outcome: model_pool=exhausted; selected_model=none.
• Head SHA: 3f5cdea75b5e4810cbbf757704c461431b968a93
• Workflow run: 28512454591
• Workflow attempt: 2

No PR approval was posted because model-output failure is not evidence that the PR has no blockers.

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["CI script: test_strix_quick_gate.sh"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: test_strix_quick_gate.sh"]
R2 --> V2["bash -n plus Strix self-test"]
Evidence --> S3["Test: test_opencode_agent_contract.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_opencode_agent_contract.py"]
R3 --> V3["targeted test run"]

Loading

[github-actions]

HIGH OpenCode could not establish approval sufficiency

• Problem: the model pool exhausted without a valid current-head review control block, so this changed line cannot be approved from deterministic check state alone.
• Impact: PR-intent mismatches, missing files, robustness bugs, UX/DX regressions, and CodeGraph-backed flow changes could be missed.
• Fix: rerun OpenCode after model availability recovers, or add the missing source/test/docs/generated verification evidence needed for a source-backed approval.
• Verification: rerun the OpenCode Review workflow and confirm it emits APPROVE or source-backed REQUEST_CHANGES for this head SHA.

[github-actions]

OpenCode Review Overview

• Head SHA: 3f5cdea75b5e4810cbbf757704c461431b968a93
• Workflow run: 28512454591
• Workflow attempt: 2
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode exhausted the configured model pool without a usable current-head review conclusion. This is not approval evidence, so the PR is blocked until a source-backed review can establish approval sufficiency or identify concrete fixes.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - OpenCode could not establish approval sufficiency

• Problem: every configured model path failed to produce a usable current-head control block.
• Root cause: model execution, timeout, export, normalization, or approval-gate validation did not complete after exponential retry across the configured model pool.
• Impact: approving from deterministic check state alone would miss PR-intent mismatches, missing files, edge-case bugs, robustness gaps, UX/DX regressions, security issues, and CodeGraph-backed base/head flow changes.
• Fix: rerun OpenCode after model availability recovers, or update the PR with the missing files, tests, docs, generated artifacts, and verification evidence needed for a source-backed review conclusion.
• Regression test: keep the approval gate posting REQUEST_CHANGES, not APPROVE or check-only failure, when no model produces a valid current-head review.

Summary

• Result: REQUEST_CHANGES
• Reason: coverage-evidence passed and peer GitHub Checks completed without failures, but no model produced a valid review control block.
• Deterministic evidence checked but not used for approval: current-head changed-file evidence (.github/workflows/opencode-review.yml, scripts/ci/test_strix_quick_gate.sh, tests/test_opencode_agent_contract.py); coverage-evidence result success; peer checks from statusCheckRollup excluding this OpenCode check.
• Model outcome: model_pool=exhausted; selected_model=none.
• Head SHA: 3f5cdea75b5e4810cbbf757704c461431b968a93
• Workflow run: 28512454591
• Workflow attempt: 2

No PR approval was posted because model-output failure is not evidence that the PR has no blockers.

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["CI script: test_strix_quick_gate.sh"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: test_strix_quick_gate.sh"]
R2 --> V2["bash -n plus Strix self-test"]
Evidence --> S3["Test: test_opencode_agent_contract.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_opencode_agent_contract.py"]
R3 --> V3["targeted test run"]

Loading

[seonghobae]

Superseded by #383. #383 is the current central OpenCode review-budget path: DeepSeek V3 first, 90-minute per-model review window, bounded pool budget, and visible failure reason publication. This older PR is dirty and has requested changes.