Skip to content

🎨 Palette: 루트 디렉토리의 빈 타이틀 및 헤딩 접근성 개선 - #175

Closed
seonghobae wants to merge 4 commits into
masterfrom
palette/fix-empty-root-title-11049101767340982608
Closed

🎨 Palette: 루트 디렉토리의 빈 타이틀 및 헤딩 접근성 개선#175
seonghobae wants to merge 4 commits into
masterfrom
palette/fix-empty-root-title-11049101767340982608

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 루트 디렉토리 크롤링 시 생성되는 index.html에서 <title><h1> 태그의 내용이 비어 있는 문제를 수정했습니다. 디렉토리 이름이 비어 있을 경우 절대 경로(absolutePath)를 표시하도록 폴백 로직을 추가했습니다.
🎯 Why: 루트 디렉토리(/)의 경우 Java의 File.getName()이 빈 문자열을 반환합니다. 이로 인해 브라우저 탭에 아무것도 표시되지 않고 스크린 리더 사용자가 페이지 맥락을 파악할 수 없게 되어 UX와 접근성에 심각한 문제가 발생했습니다.
📸 Before/After:

  • Before: <title></title>, <h1></h1> (루트 디렉토리일 경우)
  • After: <title>/</title>, <h1>/</h1> (또는 해당 시스템의 루트 경로 표시)
    ♿ Accessibility: 스크린 리더가 올바르게 제목을 읽을 수 있도록 페이지의 <title><h1> 태그에 항상 적절한 텍스트가 제공되도록 개선했습니다.

PR created automatically by Jules for task 11049101767340982608 started by @seonghobae

루트 디렉토리(`/`)를 크롤링할 때 `File.getName()`이 빈 문자열을 반환하여
HTML의 `<title>`과 `<h1>`이 비어 있는 문제가 있었습니다.
이를 절대 경로를 대신 표시하도록 수정하여 UX와 접근성을 개선했습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

루트 디렉토리(`/`)를 크롤링할 때 `File.getName()`이 빈 문자열을 반환하여
HTML의 `<title>`과 `<h1>`이 비어 있는 문제가 있었습니다.
이를 절대 경로를 대신 표시하도록 수정하여 UX와 접근성을 개선했습니다.
@opencode-agent

opencode-agentBot commented Jul 14, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: 0d76b058b0700c81d136184b6dd17fadffbf08f8
  • Workflow run: 29307440724
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 0d76b058b0700c81d136184b6dd17fadffbf08f8.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Loading

루트 디렉토리(`/`)를 크롤링할 때 `File.getName()`이 빈 문자열을 반환하여
HTML의 `<title>`과 `<h1>`이 비어 있는 문제가 있었습니다.
이를 절대 경로 대신 루트를 명시하는 `/`로 대체하여 표시하도록 수정하여 UX와 접근성을 개선했습니다.
루트 디렉토리(`/`)를 크롤링할 때 `File.getName()`이 빈 문자열을 반환하여
HTML의 `<title>`과 `<h1>`이 비어 있는 문제가 있었습니다.
이 경우 명시적으로 "루트 디렉토리"라는 문구를 출력하도록 폴백 로직을 추가하여 UX와 스크린 리더 접근성을 개선했습니다.

@opencode-agentopencode-agentBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 0d76b058b0700c81d136184b6dd17fadffbf08f8.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Loading

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by draft canonical #364. The same filesystem-root absolute-path fallback is retained there under a bounded post-#363 accessibility contract. #364 must centralize one escaped display label reused in <title> and <h1>, prove root and ordinary generated pages, add APA 7 HTML/WCAG doctoring and CHANGELOG.md, and pass fresh exact-current-head quality/security checks plus independent approval. No check or review from this duplicate head is reused.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by draft canonical #364. The same filesystem-root absolute-path fallback is retained there under a bounded post-#363 accessibility contract. #364 must centralize one escaped display label reused in <title> and <h1>, prove root and ordinary generated pages, add APA 7 HTML/WCAG doctoring and CHANGELOG.md, and pass fresh exact-current-head quality/security checks plus independent approval. No check or review from this duplicate head is reused.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae