Skip to content

🎨 Palette: 빈 디렉토리 상태 메시지에 role="status" 추가 - #236

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-status-17219880337230985203
Closed

🎨 Palette: 빈 디렉토리 상태 메시지에 role="status" 추가#236
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-status-17219880337230985203

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 생성된 디렉토리 트리의 "이 디렉토리는 비어 있습니다." 상태 메시지에 role="status" 속성을 추가했습니다.
🎯 Why: 기존 메시지는 시각적으로는 구별되나 스크린 리더에서는 단순 텍스트로 읽고 넘어갈 수 있어, 빈 상태(Empty State)라는 컨텍스트를 제대로 전달하기 위함입니다.
📸 Before/After:

  • Before: <div class="empty-dir">이 디렉토리는 비어 있습니다.</div>
  • After: <div class="empty-dir" role="status">이 디렉토리는 비어 있습니다.</div>
    Accessibility: 스크린 리더가 해당 요소를 상태 메시지로 올바르게 인식하고 사용자에게 안내할 수 있도록 향상되었습니다.

PR created automatically by Jules for task 17219880337230985203 started by @seonghobae

빈 디렉토리를 나타내는 상태 메시지에 `role="status"`를 추가하여 스크린 리더 사용자가 이를 단순 텍스트가 아닌 상태 변화로 인지할 수 있도록 접근성을 개선했습니다.
CopilotAI review requested due to automatic review settings July 21, 2026 20:59
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ARIA semantics to the generated empty-directory message so assistive technologies can recognize it as a status message, and updates tests/docs accordingly.

Changes:

  • Add role="status" to the empty-directory message element in generated index.html.
  • Extend MainTest.testGoEmptyDir to assert the new ARIA role is present.
  • Document the accessibility rationale/action in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
src/main/kotlin/html4tree/main.ktAdds role="status" to the empty-state message markup when a directory listing is empty.
src/test/kotlin/html4tree/MainTest.ktUpdates the empty-directory test to check for the new role attribute in generated HTML.
.jules/palette.mdRecords the accessibility learning/action for adding role="status" to empty-state messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

val htmlContent = indexFile.readText()
assertTrue(htmlContent.contains("<html lang=\"ko\">"))
assertTrue(htmlContent.contains("이 디렉토리는 비어 있습니다."))
assertTrue(htmlContent.contains("role=\"status\""))
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by #262 at exact head 642fc98ae09329e158e6cba9974a7894c89dd3e3. This branch's role="status" change is a strict subset of #262, which also includes the empty-state icon, aria-hidden="true", alignment styling, and expanded regression coverage. Consolidating prevents duplicate conflict resolution and redundant exact-head checks.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #262 at exact head 642fc98ae09329e158e6cba9974a7894c89dd3e3. This branch's role="status" change is a strict subset of #262, which also includes the empty-state icon, aria-hidden="true", alignment styling, and expanded regression coverage. Consolidating prevents duplicate conflict resolution and redundant exact-head checks.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seonghobae