Skip to content

🎨 Palette: 빈 디렉토리 상태 메시지에 접근성 개선 추가 - #245

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-accessibility-empty-state-572414385812584952
Closed

🎨 Palette: 빈 디렉토리 상태 메시지에 접근성 개선 추가#245
seonghobae wants to merge 1 commit into
masterfrom
palette-accessibility-empty-state-572414385812584952

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 빈 디렉토리 상태를 나타내는 <div> 요소에 role="status" ARIA 속성을 추가했습니다.
🎯 Why: 스크린 리더 사용자가 시각적으로 비어 있음을 나타내는 텍스트를 인지하기 어렵기 때문에 상태 메시지를 명확히 전달하기 위함입니다.
📸 Before/After: <div class="empty-dir">...</div> -> <div class="empty-dir" role="status">...</div>
♿ Accessibility: 정적 HTML에서도 상태 메시지에 role="status"를 부여하여 접근성을 향상시켰습니다.


PR created automatically by Jules for task 572414385812584952 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

CopilotAI review requested due to automatic review settings July 22, 2026 20:48

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the accessibility of html4tree’s generated directory listing HTML by marking the empty-directory message as a status message for assistive technologies.

Changes:

  • Add role="status" to the empty-directory message element in generated index.html.
  • Update MainTest.testGoEmptyDir to check for the new role="status" attribute.
  • Record the accessibility learning/action in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
src/main/kotlin/html4tree/main.ktAdds role="status" to the empty-directory message markup.
src/test/kotlin/html4tree/MainTest.ktAdds an assertion to verify the presence of role="status" in generated HTML.
.jules/palette.mdDocuments the accessibility improvement as a Palette learning/action entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

assertTrue(htmlContent.contains("<html lang=\"ko\">"))
assertTrue(htmlContent.contains("이 디렉토리는 비어 있습니다."))
assertTrue(htmlContent.contains("role=\"list\""))
assertTrue(htmlContent.contains("role=\"status\""))
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by #262 at exact head 642fc98ae09329e158e6cba9974a7894c89dd3e3. The same role="status" change is fully represented there, along with the aligned decorative folder icon, aria-hidden="true", and broader tests. Keeping one canonical branch avoids duplicate conflict repairs and redundant CI.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #262 at exact head 642fc98ae09329e158e6cba9974a7894c89dd3e3. The same role="status" change is fully represented there, along with the aligned decorative folder icon, aria-hidden="true", and broader tests. Keeping one canonical branch avoids duplicate conflict repairs and redundant CI.

Understood. Acknowledging that this work is now superseded by #262 and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seonghobae