Skip to content

🎨 Palette: [접근성] 루트 디렉토리의 빈 이름(Title, H1) 해결 - #248

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-fix-empty-dirname-2883572649774480488
Closed

🎨 Palette: [접근성] 루트 디렉토리의 빈 이름(Title, H1) 해결#248
seonghobae wants to merge 1 commit into
masterfrom
palette-fix-empty-dirname-2883572649774480488

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 빈 디렉토리 이름이 주어질 경우(루트 디렉토리 등), 절대 경로(absolutePath)로 폴백하도록 <title><h1> 태그 생성 로직을 개선했습니다.
🎯 Why: File.getName()은 루트 디렉토리("/")에서 빈 문자열을 반환합니다. 이로 인해 <title><h1>이 비어 있는 채로 렌더링되어 스크린 리더 등 보조 기기를 사용하는 사용자에게 페이지의 컨텍스트(현재 디렉토리 위치)를 제공하지 못하는 심각한 접근성 문제가 발생했습니다.
📸 Before/After: (시각적 변화 없음) 루트 디렉토리 크롤링 시 브라우저 탭과 페이지 최상단에 빈 문자열 대신 절대 경로(예: /)가 표시됨.
♿ Accessibility: 빈 <title><h1> 태그로 인해 화면 판독기가 문서 제목을 읽지 못하는 문제를 해결하고, 항상 설명적인 텍스트가 존재하도록 보장합니다.


PR created automatically by Jules for task 2883572649774480488 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

CopilotAI review requested due to automatic review settings July 23, 2026 03:19

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

루트 디렉토리처럼 File.getName()이 빈 문자열을 반환하는 경우에도 생성되는 index.html<title>/<h1>가 항상 의미 있는 텍스트를 갖도록 폴백 로직을 추가해, 스크린 리더 등 보조기기 사용 시 문서 컨텍스트가 비는 접근성 문제를 방지합니다.

Changes:

  • <title><h1>에 디렉토리 이름이 비어 있을 때 absolutePath로 폴백하도록 수정
  • 빈 디렉토리 이름 폴백 동작을 검증하는 테스트 추가
  • 해당 접근성 이슈에 대한 Palette 학습/조치 문서 항목 추가

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
src/main/kotlin/html4tree/main.kt디렉토리 이름이 비어 있을 때 <title>/<h1>absolutePath를 사용하도록 폴백 추가
src/test/kotlin/html4tree/MainTest.kt빈 이름 디렉토리에서 <title>/<h1> 폴백이 적용되는지 테스트 추가
.jules/palette.md빈 이름 디렉토리 접근성 이슈에 대한 학습/조치 항목 추가

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.jules/palette.md
Comment on lines +51 to +53
## 2026-07-23 - Empty Directory Name Accessibility Issue
**Learning:** When generating a directory tree for the root of a file system (where `File.getName()` returns an empty string), empty `<title>` and `<h1>` tags are generated. This causes the page to lack a descriptive title, hurting screen reader accessibility.
**Action:** Use a fallback to `File.getAbsolutePath()` when the directory name is empty to ensure title and header tags always have meaningful context.
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by draft canonical #364. The same absolute-path fallback for an empty filesystem-root name is retained there under a bounded post-#363 accessibility contract. #364 must centralize one escaped label, prove root/non-root generated output, add APA 7 doctoring and changelog, and pass fresh exact-head checks plus independent approval. No evidence from this duplicate head is reused.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by draft canonical #364. The same absolute-path fallback for an empty filesystem-root name is retained there under a bounded post-#363 accessibility contract. #364 must centralize one escaped label, prove root/non-root generated output, add APA 7 doctoring and changelog, and pass fresh exact-head checks plus independent approval. No evidence from this duplicate head is reused.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seonghobae