Uh oh!
There was an error while loading. Please reload this page.
🎨 Palette: 빈 디렉토리 이름(루트 디렉토리 등) 폴백 처리로 접근성 향상 - #258
Conversation
디렉토리 이름이 비어 있을 때(예: 파일시스템 루트) 절대 경로를 사용하도록 폴백을 추가하여, 빈 <title>과 <h1> 태그가 스크린 리더 사용자에게 컨텍스트를 제공하지 못하는 접근성 문제를 해결했습니다. 빈 이름을 방지함으로써 스크린 리더가 내비게이션 트리의 현재 위치를 올바르게 읽을 수 있도록 보장합니다.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility of generated directory listing pages by ensuring the HTML <title> and <h1> never render as empty when a directory’s name is empty, falling back to the directory’s absolute path instead. This aligns with html4tree’s goal of generating safe, usable static index.html listings.
Changes:
- Add an empty-name fallback (
absolutePath) for the generated page<title>and<h1>inprocess_dir. - Add a regression test covering the empty directory name fallback behavior.
- Record the learned accessibility guideline in
.jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/html4tree/main.kt | Uses curr_dir.name.ifEmpty { curr_dir.absolutePath } for <title> and <h1> to avoid empty headings. |
| src/test/kotlin/html4tree/MainTest.kt | Adds a test that simulates an empty directory name and asserts fallback content is present in the generated HTML. |
| .jules/palette.md | Documents the learning/action about handling empty directory names to prevent empty <title>/<h1> for accessibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head.Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence.Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.Result: REQUEST_CHANGES
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head5b17beb16089f4237eb5efe7d9004d713114a3a9.Head SHA:
5b17beb16089f4237eb5efe7d9004d713114a3a9Workflow run: 30424283287
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
seonghobae
commented
Aug 5, 2026
Closing as superseded by #364. Both branches provide the same escaped absolute-path fallback when a filesystem root has an empty directory name, preventing empty page titles and headings. #364 carries the consolidated implementation and regression on the current base; this older branch is non-mergeable and would duplicate conflict resolution and review. |
Understood. Acknowledging that this work is now superseded by #364 and stopping work on this task. |
💡 What: 디렉토리 이름이 비어 있을 때(예: 파일시스템 루트) 절대 경로를 사용하도록 폴백을 추가했습니다.
🎯 Why: 빈
<title>과<h1>태그는 스크린 리더 사용자에게 컨텍스트를 제공하지 못하여 접근성 문제를 일으킵니다.📸 Before/After: 해당 없음 (시각적 구조 변경보다는 DOM 노드 컨텐츠 변경에 중점)
♿ Accessibility: 빈 이름을 방지하여 스크린 리더가 내비게이션 트리의 현재 위치를 올바르게 읽을 수 있도록 보장합니다.
PR created automatically by Jules for task 8913576277332354294 started by @seonghobae