Skip to content

🎨 Palette: 빈 디렉토리 시각적/시맨틱 구분 추가 - #260

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-icon-12578034918511239289
Closed

🎨 Palette: 빈 디렉토리 시각적/시맨틱 구분 추가#260
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-icon-12578034918511239289

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: 빈 디렉토리와 내용이 있는 디렉토리를 시각적 및 시맨틱하게 구분하는 기능을 추가했습니다.
🎯 Why: 사용자가 빈 디렉토리를 불필요하게 클릭하여 탐색하는 불편함을 줄이고 접근성을 향상시키기 위함입니다.
♿ Accessibility: aria-labeltitle 속성에 "빈 디렉토리"를 추가하여 스크린 리더 사용자가 해당 디렉토리가 비어있음을 명확히 인지할 수 있도록 개선했습니다.


PR created automatically by Jules for task 12578034918511239289 started by @seonghobae

빈 디렉토리를 닫힌 폴더 아이콘(📁) 대신 열린 폴더 아이콘(📂)으로 구분하고, aria-label 및 title에 '빈 디렉토리'를 명시하여 불필요한 디렉토리 탐색을 방지하는 접근성 개선 사항을 추가했습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

CopilotAI review requested due to automatic review settings July 24, 2026 20:52

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

빈 디렉토리와 내용이 있는 디렉토리를 HTML 인덱스에서 시각적(아이콘) 및 시맨틱(aria-label/title)으로 구분해, 불필요한 탐색 클릭을 줄이고 접근성을 개선하는 변경입니다.

Changes:

  • 디렉토리 엔트리에 대해 “빈 디렉토리” 여부를 확인하고 아이콘(📂/📁) 및 aria-label/title 텍스트를 분기 처리
  • 빈 디렉토리 표시 동작을 검증하는 테스트 추가 및 기존 테스트가 새 동작과 충돌하지 않도록 보강
  • Palette 학습 로그에 “빈 디렉토리 구분” 원칙 추가

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

FileDescription
src/main/kotlin/html4tree/main.kt디렉토리 비어있음 여부 판정 후 아이콘/라벨을 “빈 디렉토리”로 구분 표시
src/test/kotlin/html4tree/MainTest.kt빈 디렉토리 아이콘/라벨 검증 테스트 추가 및 기존 디렉토리 테스트 보강
src/test/kotlin/html4tree/AttrExceptionTest.kt빈 디렉토리 판정 경로의 예외 발생 시에도 인덱스 생성이 지속됨을 검증
.jules/palette.md“빈 디렉토리 구분”에 대한 학습/조치 항목 추가

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +366 to +371
val stream = newDirectoryStream(it.toPath())
try {
isEmptyDir = !stream.iterator().hasNext()
} finally {
stream.close()
}
@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing this stale child-emptiness preflight branch. Although it injects the stream boundary for a failure test, the production design still enumerates each child directory a second time solely to decorate the parent listing, then silently treats filesystem errors as “not empty.” That adds hot-path I/O and a race-prone hint whose truth can change immediately after the probe. Keep the renderer snapshot-based; the current directory can communicate its own empty state cheaply in #385.

@google-labs-jules

Copy link
Copy Markdown

Closing this stale child-emptiness preflight branch. Although it injects the stream boundary for a failure test, the production design still enumerates each child directory a second time solely to decorate the parent listing, then silently treats filesystem errors as “not empty.” That adds hot-path I/O and a race-prone hint whose truth can change immediately after the probe. Keep the renderer snapshot-based; the current directory can communicate its own empty state cheaply in #385.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seonghobae