Skip to content

🎨 Palette: 빈 디렉토리 상태에 시각적 일관성 향상 - #268

Closed
seonghobae wants to merge 1 commit into
masterfrom
ux/empty-state-icon-14103964926405385154
Closed

🎨 Palette: 빈 디렉토리 상태에 시각적 일관성 향상#268
seonghobae wants to merge 1 commit into
masterfrom
ux/empty-state-icon-14103964926405385154

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

디렉토리가 비어 있을 때 표시되는 메시지에 열린 폴더 아이콘과 Flex 레이아웃을 적용하여 시각적 일관성을 향상시켰습니다. 빈 상태 메시지도 일반 파일/폴더 목록과 동일한 들여쓰기와 아이콘 구조를 갖게 되어 사용자가 쉽게 인지할 수 있습니다. 이모지는 화면 판독기에서 읽히지 않도록 aria-hidden="true"로 처리했습니다.


PR created automatically by Jules for task 14103964926405385154 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

CopilotAI review requested due to automatic review settings July 25, 2026 20:46

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

빈 디렉토리(Empty State)일 때의 안내 메시지를 일반 목록 항목과 동일한 “아이콘 + 텍스트” 구조로 맞추고, Flex 레이아웃을 적용해 시각적 일관성을 높이는 변경입니다. aria-hidden="true"로 아이콘을 숨겨 스크린 리더 경험도 유지합니다.

Changes:

  • .empty-dir에 Flex 레이아웃/정렬/gap을 추가해 목록 항목과 동일한 레이아웃 기반을 마련
  • 빈 디렉토리 메시지에 열린 폴더 아이콘(&#128194;) + 텍스트 <span> 구조를 추가
  • 테스트에 빈 상태 아이콘 출력 여부를 검증하는 assertion 추가, 관련 학습 로그 문서 업데이트

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
src/main/kotlin/html4tree/main.kt빈 상태 메시지의 HTML 구조를 “아이콘 + 텍스트”로 변경하고 .empty-dir에 Flex 스타일 추가
src/test/kotlin/html4tree/MainTest.kt빈 디렉토리 결과 HTML에 열린 폴더 아이콘 엔티티가 포함되는지 검증 추가
.jules/palette.md빈 상태 시각적 일관성 개선에 대한 학습/조치 기록 추가

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by canonical #262 at exact head b72a62d9fb4e2597d3989d9b6d421aaf4ca38231. This PR's empty-state flex layout, decorative open-folder icon, and aria-hidden behavior are fully contained there; #262 also adds role="status" and a fragment-scoped regression test that cannot pass on unrelated icons. Consolidation avoids competing conflict repairs and duplicate CI.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by canonical #262 at exact head b72a62d9fb4e2597d3989d9b6d421aaf4ca38231. This PR's empty-state flex layout, decorative open-folder icon, and aria-hidden behavior are fully contained there; #262 also adds role="status" and a fragment-scoped regression test that cannot pass on unrelated icons. Consolidation avoids competing conflict repairs and duplicate CI.

Understood. Acknowledging that this PR is superseded by #262 and closing this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seonghobae