Uh oh!
There was an error while loading. Please reload this page.
🎨 Palette: 루트 디렉토리 이름 Fallback 추가 - #273
Conversation
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the generated directory listing HTML so that when File.getName() is empty (notably for filesystem root directories), the page <title> and <h1> fall back to using the directory’s absolutePath, improving context for users (including screen reader users).
Changes:
- Add
dirNameToDisplayfallback (name→absolutePathwhen empty) and use it for<title>/<h1>inprocess_dir. - Add a unit test covering the empty-name fallback behavior.
- Document the learned rule and action in
.jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/html4tree/main.kt | Adds a display-name fallback for empty directory names and applies it to <title>/<h1>. |
| src/test/kotlin/html4tree/MainTest.kt | Adds a regression test validating the fallback behavior when getName() returns "". |
| .jules/palette.md | Documents the root-directory empty-name behavior and the recommended fallback approach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ${cssContent} </style> | ||
| """ | ||
| val dirNameToDisplay = curr_dir.getName().ifEmpty { curr_dir.absolutePath } |
seonghobae
commented
Aug 5, 2026
Closing as superseded by draft canonical #364. The same absolute-path fallback for filesystem roots is retained there under a bounded post-#363 accessibility contract. #364 must still centralize one escaped display label, prove root and ordinary generated pages, add APA 7 doctoring and changelog, and pass fresh exact-head quality/security checks plus independent approval. No evidence from this duplicate head is reused. |
Understood. Acknowledging that this work is now superseded by #364 and stopping work on this task. |
💡 What (추가된 기능)
File.getName()이 빈 문자열을 반환하는 경우,absolutePath를 Fallback으로 사용하여<title>및<h1>를 생성하도록 변경했습니다.🎯 Why (해결한 사용자 문제)
<title>및<h1>요소가 완전히 비어 있어, 사용자(특히 스크린 리더 사용자)가 현재 위치를 파악하기 어려웠습니다.📸 Before/After
<title></title>,<h1></h1>(루트 디렉토리의 경우)<title>/</title>,<h1>/</h1>등absolutePath를 표시.♿ Accessibility (접근성 개선 사항)
PR created automatically by Jules for task 3259555537994780888 started by @seonghobae