Skip to content

⚡ Bolt: [성능 개선] 불변 정적 문자열 및 해시 계산을 함수 외부로 추출#310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

⚡ Bolt: [성능 개선] 불변 정적 문자열 및 해시 계산을 함수 외부로 추출 #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,3 +43,6 @@
## 2025-01-24 - 단일 readAttributes 호출로 파일 속성 조회 최적화
**학습:** `isDirectory`, `!it.isDirectory()`, `isSymbolicLink` 3개의 개별적인 파일 시스템 I/O 호출을 수행하면 성능 저하가 큽니다. 이를 단일 `Files.readAttributes` 호출로 변경하여 메타데이터를 한 번에 조회함으로써 I/O 오버헤드를 대폭 줄일 수 있음을 확인했습니다.
**조치:** 디렉토리 순회 시 파일의 여러 속성을 확인할 때는 개별적인 stat 호출보다 `Files.readAttributes`를 사용하여 필요한 모든 속성을 한 번에 가져오는 방식을 우선적으로 고려해야 합니다.
## 2026-07-30 - 불변 정적 문자열 및 비용이 큰 해시 계산의 루프/함수 외부 추출
**Learning:** `process_dir`와 같이 빈번하게 호출되는 함수 내에서 SHA-256과 같은 무거운 해시 연산을 수행하고 거대한 정적 문자열을 생성하면 심각한 성능 저하와 GC 압박이 발생합니다.
**Action:** 불변인 정적 데이터와 그에 따른 해시값은 함수 외부의 파일 최상단 `private val` 상수로 추출하여 단 한 번만 계산되도록 최적화해야 합니다. 또한 Kotlin에서 `private`으로 선언해야 불필요한 getter 생성을 막아 Jacoco 커버리지 100%를 유지할 수 있습니다.
15 changes: 8 additions & 7 deletions src/main/kotlin/html4tree/main.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -240,11 +240,8 @@ fun write_index_file(curr_dir: File, content: String) {
}
}

fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array<File>? = null){

val exclude: Set<String> = excludeSet ?: process_ignore_file(curr_dir)

val cssContent = """
// ⚡ Bolt Performance Optimization: Hoist invariant static strings and expensive computations (like SHA-256 hashing) out of process_dir to prevent redundant allocations and processing overhead.
private val cssContent = """
body {
font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", sans-serif;
line-height: 1.5;
Expand DownExpand Up@@ -310,13 +307,17 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array
}
"""

val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8)))
private val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8)))

val css = """
private val css = """
<style>
${cssContent} </style>
"""
Comment on lines +310 to 315

@coderabbitaicoderabbitaiBotJul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bashset -euo pipefail
printf'\n== main.kt slice ==\n'
sed -n '280,340p' src/main/kotlin/html4tree/main.kt
printf'\n== search styleHash/cssContent/tests ==\n'
rg -n "styleHash|cssContent|Content-Security-Policy|<style>|sha256-" src test.||true

Repository: ContextualWisdomLab/html4tree

Length of output: 4229

🏁 Script executed:

#!/bin/bashset -euo pipefail
python3 - <<'PY'from pathlib import Pathp = Path('src/main/kotlin/html4tree/main.kt')text = p.read_text()for needle in ['cssContent', 'styleHash', 'private val css =', 'Content-Security-Policy', '<style>']: idx = text.find(needle) print(f'-- {needle} @ {idx}') if idx != -1: start = text.rfind('\n', 0, idx) end = text.find('\n', idx) print(text[max(0, start-200):min(len(text), end+200)]) print()PYprintf'\n== tests ==\n'
git ls-files | rg 'test|Test|Spec'||true

Repository: ContextualWisdomLab/html4tree

Length of output: 2854

🏁 Script executed:

#!/bin/bashset -euo pipefail
printf'\n== main.kt cssContent section ==\n'
sed -n '244,320p' src/main/kotlin/html4tree/main.kt
printf'\n== MainTest CSP section ==\n'
sed -n '300,360p' src/test/kotlin/html4tree/MainTest.kt
printf'\n== exact string/hash probe ==\n'
python3 - <<'PY'from pathlib import Pathimport re, base64, hashlibtext = Path('src/main/kotlin/html4tree/main.kt').read_text()# Extract cssContent raw triple-quoted string and css template.m = re.search(r'private val cssContent = """(.*?)"""', text, re.S)css_content = m.group(1)m2 = re.search(r'private val css = """(.*?)"""', text, re.S)css_template = m2.group(1)actual_style_body = "\n" + css_content + " "hash_css_content = "sha256-" + base64.b64encode(hashlib.sha256(css_content.encode('utf-8')).digest()).decode()hash_actual_body = "sha256-" + base64.b64encode(hashlib.sha256(actual_style_body.encode('utf-8')).digest()).decode()print("css_content repr tail:", repr(css_content[-80:]))print("css_content endswith newline:", css_content.endswith("\n"))print("actual_style_body repr tail:", repr(actual_style_body[-80:]))print("hash(cssContent):", hash_css_content)print("hash(actual style body):", hash_actual_body)print("match:", hash_css_content == hash_actual_body)# Show raw bytes diff at endprint("css_content bytes tail:", list(css_content.encode('utf-8')[-20:]))print("actual bytes tail:", list(actual_style_body.encode('utf-8')[-20:]))PY

Repository: ContextualWisdomLab/html4tree

Length of output: 6672

🏁 Script executed:

#!/bin/bashset -euo pipefail
printf'\n== main.kt cssContent section ==\n'
sed -n '244,320p' src/main/kotlin/html4tree/main.kt
printf'\n== MainTest CSP section ==\n'
sed -n '300,360p' src/test/kotlin/html4tree/MainTest.kt
printf'\n== exact string/hash probe ==\n'
python3 - <<'PY'from pathlib import Pathimport re, base64, hashlibtext = Path('src/main/kotlin/html4tree/main.kt').read_text()# Extract cssContent raw triple-quoted string and css template.m = re.search(r'private val cssContent = """(.*?)"""', text, re.S)css_content = m.group(1)m2 = re.search(r'private val css = """(.*?)"""', text, re.S)css_template = m2.group(1)actual_style_body = "\n" + css_content + " "hash_css_content = "sha256-" + base64.b64encode(hashlib.sha256(css_content.encode('utf-8')).digest()).decode()hash_actual_body = "sha256-" + base64.b64encode(hashlib.sha256(actual_style_body.encode('utf-8')).digest()).decode()print("css_content repr tail:", repr(css_content[-80:]))print("css_content endswith newline:", css_content.endswith("\n"))print("actual_style_body repr tail:", repr(actual_style_body[-80:]))print("hash(cssContent):", hash_css_content)print("hash(actual style body):", hash_actual_body)print("match:", hash_css_content == hash_actual_body)# Show raw bytes tailprint("css_content bytes tail:", list(css_content.encode('utf-8')[-20:]))print("actual bytes tail:", list(actual_style_body.encode('utf-8')[-20:]))PY

Repository: ContextualWisdomLab/html4tree

Length of output: 6672

<style> 본문과 CSP 해시를 같은 문자열로 맞추세요.
지금은 cssContent만 해시하지만, 렌더링된 본문에는 </style> 앞 공백이 추가되어 해시가 달라집니다. 실제 본문 문자열을 만들어 해시와 HTML 양쪽에서 재사용하고, 테스트도 해시 형식뿐 아니라 본문 일치까지 확인해야 합니다.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/kotlin/html4tree/main.kt` around lines 310 - 315, Update the style
content construction around styleHash and css so the exact rendered text between
the style tags is created once and reused for both the CSP hash input and HTML
output. Include the existing whitespace before </style> in that shared body, and
extend the related tests to verify the hash is computed from the rendered body,
not only that its format is valid.


fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array<File>? = null){

val exclude: Set<String> = excludeSet ?: process_ignore_file(curr_dir)

val index_top = """<!doctype html>
<html lang="ko">
<head>
Expand Down
Loading