Skip to content

🎨 Palette: 빈 디렉토리 상태의 접근성 개선 - #316

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette/a11y-empty-dir-state-12936661342163853124
Closed

🎨 Palette: 빈 디렉토리 상태의 접근성 개선#316
seonghobae wants to merge 1 commit into
masterfrom
palette/a11y-empty-dir-state-12936661342163853124

Conversation

@seonghobae

@seonghobaeseonghobae commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

💡 What: 빈 디렉토리 상태(<div class="empty-dir">)에 장식용 폴더 아이콘(&#128194;)과 함께 role="status", aria-hidden="true" 속성을 추가하고, 해당 요소들이 수평으로 정렬되도록 .empty-dir CSS에 flexbox 속성을 적용했습니다.
🎯 Why: 스크린 리더 사용자가 볼 수 없는 빈 디렉토리에 접근했을 때 상태 변화를 즉각 인지할 수 있게 하고, 시각적으로도 빈 폴더라는 의미를 직관적으로 전달하기 위함입니다.
📸 Before/After: 시각적으로 기울임꼴 글꼴만 있던 기존 방식에서, 열린 폴더 아이콘이 추가되고 아이콘과 텍스트가 나란히 수평 정렬되는 방식으로 변경되었습니다.
♿ Accessibility: role="status"를 통해 보조 기기가 상태 메시지를 즉시 안내하게 하며, 장식용 이모지에는 aria-hidden="true"를 적용하여 불필요하게 소리내어 읽히지 않도록 개선했습니다.


PR created automatically by Jules for task 12936661342163853124 started by @seonghobae

Summary by CodeRabbit

  • 접근성 개선

    • 빈 디렉토리 화면에 상태 메시지 역할을 적용해 보조 기술이 내용을 인식할 수 있도록 개선했습니다.
    • 장식용 아이콘이 불필요하게 읽히지 않도록 설정했습니다.
  • UI 개선

    • 빈 디렉토리 아이콘과 메시지의 배치 및 간격을 개선했습니다.
  • 문서

    • 빈 목록 상태 구현을 위한 접근성 지침을 추가했습니다.

빈 상태(Empty State) 메시지에 `role="status"`를 부여하여 스크린 리더 사용자가 상태를 즉시 인지할 수 있도록 개선하고, 장식용 아이콘에 `aria-hidden="true"`를 적용하여 불필요한 정보 노출을 방지했습니다. 또한 빈 상태 메시지가 아이콘과 자연스럽게 배치되도록 CSS(flexbox)를 업데이트했습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

빈 디렉토리 표시가 접근성 속성과 분리된 아이콘·메시지 구조를 사용하도록 변경되었으며, flex 레이아웃과 관련 테스트 및 문서가 추가되었습니다.

Changes

빈 디렉토리 접근성 개선

Layer / File(s)Summary
빈 상태 마크업 및 검증
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt, .jules/palette.md
빈 디렉토리 HTML에 role="status"aria-hidden="true"를 적용하고 아이콘과 메시지를 분리했으며, flex 기반 스타일과 테스트·접근성 지침을 추가합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers:copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ Passed빈 디렉토리 빈 상태에 role="status", aria-hidden 및 레이아웃 개선을 반영해 변경 사항을 잘 요약합니다.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/a11y-empty-dir-state-12936661342163853124

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/test/kotlin/html4tree/MainTest.kt (1)

98-100: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

빈 상태 마크업과 Flexbox 속성을 함께 검증해 주세요.

현재 aria-hidden="true" 검증은 상위 디렉토리 링크의 장식 아이콘만으로도 통과할 수 있어, 폴더 아이콘이 실제로 숨김 처리되었는지 보장하지 않습니다. 또한 새로 추가된 .empty-dir의 Flexbox 속성도 테스트되지 않습니다.

권장 수정
- assertTrue(htmlContent.contains("role=\"status\""))- assertTrue(htmlContent.contains("&`#128194`;"))- assertTrue(htmlContent.contains("aria-hidden=\"true\""))+ assertTrue(+ htmlContent.contains(+ "<div class=\"empty-dir\" role=\"status\"><span class=\"icon\" aria-hidden=\"true\">&`#128194`;</span>"+ )+ )+ assertTrue(htmlContent.contains("display: flex;"))+ assertTrue(htmlContent.contains("align-items: center;"))+ assertTrue(htmlContent.contains("gap: 0.5rem;"))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/test/kotlin/html4tree/MainTest.kt` around lines 98 - 100, Update the test
assertions around the existing role/status, folder-icon entity, and aria-hidden
checks so they target the empty-state markup rather than any ancestor-link icon;
additionally assert that the generated .empty-dir style includes its intended
Flexbox declarations, such as display and alignment properties.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/test/kotlin/html4tree/MainTest.kt`:
- Around line 98-100: Update the test assertions around the existing
role/status, folder-icon entity, and aria-hidden checks so they target the
empty-state markup rather than any ancestor-link icon; additionally assert that
the generated .empty-dir style includes its intended Flexbox declarations, such
as display and alignment properties.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d8584918-7e84-48de-8b1d-775bd95ab3c0

📥 Commits

Reviewing files that changed from the base of the PR and between a859a11 and 964927f.

📒 Files selected for processing (3)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by the protected base and draft canonical #360. The current generated empty state already includes aligned decorative treatment and status semantics. #360 owns the remaining tested visual readability and interaction contract after #363: explicit light/dark contrast, row separators, text-only hover/focus underline with full-target focus outline, reduced motion, browser regression, WCAG 2.2 doctoring, changelog, and fresh exact-head gates. No evidence from this duplicate head is reused.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by the protected base and draft canonical #360. The current generated empty state already includes aligned decorative treatment and status semantics. #360 owns the remaining tested visual readability and interaction contract after #363: explicit light/dark contrast, row separators, text-only hover/focus underline with full-target focus outline, reduced motion, browser regression, WCAG 2.2 doctoring, changelog, and fresh exact-head gates. No evidence from this duplicate head is reused.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae