Skip to content

🎨 Palette: [접근성] 파일 시스템 루트 디렉토리의 빈 제목 방지 - #321

Closed
seonghobae wants to merge 1 commit into
masterfrom
feature/palette-a11y-empty-title-13676843166447961508
Closed

🎨 Palette: [접근성] 파일 시스템 루트 디렉토리의 빈 제목 방지#321
seonghobae wants to merge 1 commit into
masterfrom
feature/palette-a11y-empty-title-13676843166447961508

Conversation

@seonghobae

@seonghobaeseonghobae commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

💡 What: 루트 디렉토리와 같이 이름이 비어있는 디렉토리 처리 시 HTML의 <title><h1>이 비어있지 않도록 절대 경로(absolutePath)를 폴백으로 사용하도록 수정했습니다.
🎯 Why: 기존에는 파일 시스템 루트의 경우 이름이 빈 문자열로 반환되어 접근성 요소가 누락되는 문제가 있었습니다. 화면 판독기 등 보조 기술 사용자가 현재 위치를 명확히 인지할 수 있도록 합니다.
📸 Before/After: N/A (화면 표시 및 스크린 리더 음성 출력 개선)
♿ Accessibility: 비어있는 <title><h1> 태그를 방지하여 스크린 리더 사용자에게 올바른 페이지 컨텍스트를 제공합니다.


PR created automatically by Jules for task 13676843166447961508 started by @seonghobae

Summary by CodeRabbit

  • 접근성 개선

    • 루트 디렉터리처럼 이름이 비어 있는 경우에도 생성된 HTML의 제목과 첫 번째 헤딩에 의미 있는 절대 경로가 표시됩니다.
    • 디렉터리 경로는 HTML에 안전하게 표시되도록 처리됩니다.
  • 버그 수정

    • 디렉터리 이름이 비어 있을 때 HTML 제목과 헤딩이 빈 값으로 생성되던 문제를 해결했습니다.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitaiBot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ed7702f9-b05b-4979-9913-00ced099e575

📥 Commits

Reviewing files that changed from the base of the PR and between a859a11 and cbd69e4.

📒 Files selected for processing (3)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

📝 Walkthrough

Walkthrough

빈 디렉토리 이름을 사용하는 HTML의 <title><h1>에 이스케이프된 절대 경로를 표시합니다. 일반 디렉토리 이름 처리는 유지합니다. 회귀 테스트는 이 동작을 검증합니다.

Changes

빈 디렉토리 HTML 제목 처리

Layer / File(s)Summary
HTML 제목 대체 및 회귀 검증
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt, .jules/palette.md
process_dir는 빈 디렉토리 이름에 이스케이프된 absolutePath를 사용합니다. 테스트는 생성된 index.html<title><h1>을 검증합니다. 접근성 개선 항목을 기록합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers:copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ Passed제목은 파일 시스템 루트 디렉토리의 빈 HTML 제목을 방지하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/palette-a11y-empty-title-13676843166447961508

Comment @coderabbitai help to get the list of available commands.

@seonghobaeChatGPT Codex Connector

Copy link
Copy Markdown
CollaboratorAuthor

Closing as superseded by draft canonical #364. The same non-empty root page label is retained there. #364 remains blocked until it is updated after #363, reduces duplicate rendering to one escaped display value, proves root/ordinary path behavior in generated output, adds APA 7 doctoring and changelog, and passes fresh exact-head checks plus independent approval. No evidence is reused.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by draft canonical #364. The same non-empty root page label is retained there. #364 remains blocked until it is updated after #363, reduces duplicate rendering to one escaped display value, proves root/ordinary path behavior in generated output, adds APA 7 doctoring and changelog, and passes fresh exact-head checks plus independent approval. No evidence is reused.

Understood. Acknowledging that this work is now superseded by #364 and stopping work on this task.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae