Uh oh!
There was an error while loading. Please reload this page.
🎨 Palette: [UX improvement] 디렉토리 목록 네비게이션 라벨 접근성 개선 - #515
Conversation
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough디렉터리 내비게이션은 숨김 Changes디렉터리 내비게이션 개선
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to This PR updates navigation labeling for better translated screen-reader output and adjusts the related CSS selector, with accompanying test updates. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <nav aria-labelledby="nav-label"> | ||
| <span id="nav-label" class="visually-hidden">디렉토리 목록</span> |
There was a problem hiding this comment.
📝 Info: Hidden label span may be announced twice
The nav's accessible name comes from a .visually-hidden span referenced by aria-labelledby. The span is clipped, not display:none, so some screen readers announce its text both as the nav label and as in-flow content, reading "디렉토리 목록" twice.
Was this helpful? React with 👍 or 👎 to provide feedback.
| a:hover span:nth-child(2), a:focus-visible span:nth-child(2) { | ||
| text-decoration: underline; | ||
| } |
There was a problem hiding this comment.
📝 Info: Selector change fixes latent underline
The old span:last-child targeted the trailing .visually-hidden type-label span, so the hover/focus underline was never visible. span:nth-child(2) targets the visible name span (consistently the 2nd child in both the .. row and file/dir rows), so underline now applies to link text.
Was this helpful? React with 👍 or 👎 to provide feedback.
💡 What:
aria-label대신.visually-hidden클래스가 적용된 숨김 텍스트와aria-labelledby를 사용하여 네비게이션 라벨을 개선하고, 숨김 텍스트 추가로 인해 깨질 수 있는 CSS:last-child선택자를:nth-child(2)로 수정했습니다.🎯 Why: 브라우저 번역 도구가
aria-label속성을 번역하지 못해 스크린 리더 환경에서 번역되지 않은 라벨이 읽히는 접근성 문제를 해결하기 위함입니다.📸 Before/After:
<nav aria-label="디렉토리 목록">및span:last-childCSS 규칙<nav aria-labelledby="nav-label">\n<span id="nav-label" class="visually-hidden">디렉토리 목록</span>및span:nth-child(2)CSS 규칙♿ Accessibility: 스크린 리더 사용자가 페이지 번역 시 네비게이션 라벨도 모국어로 정확히 안내받을 수 있게 되어 다국어 접근성이 크게 향상되었습니다.
PR created automatically by Jules for task 4489784047601234240 started by @seonghobae
Summary by CodeRabbit
접근성 개선
사용자 경험 개선
테스트