Uh oh!
There was an error while loading. Please reload this page.
copilot-core: Remove deprecated fields of Copilot.Core.Expr.UExpr. Refs #636. - #637
Merged
ivanperez-keera merged 2 commits intoJun 28, 2025
Conversation
ivanperez-keera
commented
Jun 28, 2025
MemberAuthor
Change Manager: The commit message for the main commit has a grammatical error (singular instead of plural). |
Copilot-Language#636. The record fields uExprExpr and uExprType, part of Copilot.Core.Expr, are never really used within the module or in any other part of Copilot or, as far as we know, by any user of Copilot. The record fields were deprecated in Copilot 4.2 and no messages have been received requesting that they be kept in this library. As per our internal policy of waiting 3 versions from deprecation until a public interface declaration can be removed, these definitions can now be removed. This commit removes the fields uExprType and uExprExpr from the definition of Copilot.Core.Expr.UExpr, making the type no longer a record.
ivanperez-keeraforce-pushed
the
develop-remove-UExpr-fields
branch
from
June 28, 2025 20:02
e8ee7e4 to
2f4cc73Compareivanperez-keera
commented
Jun 28, 2025
MemberAuthor
Implementor: Fix implemented, review requested. |
ivanperez-keera
commented
Jun 28, 2025
MemberAuthor
Change Manager: Verified that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated fields of the type
Copilot.Core.Expr.UExpr, as prescribed in the solution proposed for #636.