fix(team): prevent default limit and worker recursion deadlocks by terisuke · Pull Request #184 · Cor-Incorporated/opencode

terisuke · 2026-04-25T04:57:17Z

Issue for this PR

Closes#185

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

This PR fixes two guardrail team orchestration failures.

First, it defaults strategy and limit inside team.execute(). The runtime tool args can omit schema defaults, and an omitted limit made the scheduler slice ready tasks with NaN, launching zero workers and reporting a false dependency deadlock.

Second, it makes team/background workers non-recursive. Worker sessions now receive explicit rules not to stop after a progress-only response, and their team, background, team_status, and task tools are disabled while normal edit/write tools remain available for write workers.

This branch also includes the latest upstream/dev merge before the fix.

How did you verify your code works?

bun test test/plugin/team.test.ts --timeout 30000
bun run typecheck
bunx prettier --check packages/guardrails/profile/plugins/team.ts packages/opencode/test/plugin/team.test.ts
git diff --check
pre-push hook: bun turbo typecheck

Screenshots / recordings

N/A

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

…i oauth (anomalyco#24212)

…t landed (anomalyco#19937) Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com> Co-authored-by: Brendan Allan <14191578+Brendonovich@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

…leted (anomalyco#24253)

…lt-deadlock

github-actions · 2026-04-25T04:57:26Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

Copilot

Pull request overview

This PR merges upstream changes and hardens orchestration and server tooling to prevent team worker deadlocks (missing default limits + recursive tool calls), while also expanding/standardizing the experimental HttpApi bridge and updating related docs/tooling.

Changes:

Fix team tool scheduling by defaulting strategy/limit at execute-time and disabling recursive orchestration tools inside workers; add regression tests.
Refactor experimental HttpApi auth into a shared middleware/layer (Basic + auth_token) and add bridge-level tests.
Misc upstream updates: LSP improvements (C# script + Razor), ripgrep schema migration, beta automation script tweaks, and Zen docs/model/pricing updates.

Reviewed changes

Copilot reviewed 48 out of 49 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
script/github/close-issues.ts	Adjust GitHub issue close reason to `not_planned`.
script/beta.ts	Add grouped logging + deterministic validate/commit smoke flow before beta force-push.
packages/web/src/content/docs/zen.mdx	Add GPT 5.5/GPT 5.5 Pro entries + update pricing/example.
packages/web/src/content/docs/zh-cn/zen.mdx	Same Zen doc updates (zh-CN).
packages/web/src/content/docs/zh-tw/zen.mdx	Same Zen doc updates (zh-TW).
packages/web/src/content/docs/tr/zen.mdx	Same Zen doc updates (TR).
packages/web/src/content/docs/th/zen.mdx	Same Zen doc updates (TH).
packages/web/src/content/docs/ru/zen.mdx	Same Zen doc updates (RU).
packages/web/src/content/docs/pt-br/zen.mdx	Same Zen doc updates (pt-BR).
packages/web/src/content/docs/pl/zen.mdx	Same Zen doc updates (PL).
packages/web/src/content/docs/nb/zen.mdx	Same Zen doc updates (NB).
packages/web/src/content/docs/ko/zen.mdx	Same Zen doc updates (KO).
packages/web/src/content/docs/ja/zen.mdx	Same Zen doc updates (JA).
packages/web/src/content/docs/it/zen.mdx	Same Zen doc updates (IT).
packages/web/src/content/docs/fr/zen.mdx	Same Zen doc updates (FR).
packages/web/src/content/docs/es/zen.mdx	Same Zen doc updates (ES).
packages/web/src/content/docs/de/zen.mdx	Same Zen doc updates (DE).
packages/web/src/content/docs/da/zen.mdx	Same Zen doc updates (DA).
packages/web/src/content/docs/bs/zen.mdx	Same Zen doc updates (BS).
packages/web/src/content/docs/ar/zen.mdx	Same Zen doc updates (AR).
packages/web/src/content/docs/lsp.mdx	Document C# `.csx` + new Razor LSP support.
packages/opencode/test/server/httpapi-bridge.test.ts	Add bridge-level tests for HttpApi auth + instance selection.
packages/opencode/test/plugin/team.test.ts	Add regressions for omitted limit + recursive tool disabling.
packages/opencode/src/tool/bash.txt	Clarify safe `git commit --amend` conditions.
packages/opencode/src/server/routes/instance/pty.ts	Switch PTY ID parsing to Effect Schema decoder.
packages/opencode/src/server/routes/instance/httpapi/auth.ts	Introduce shared Authorization middleware (Basic + `auth_token`).
packages/opencode/src/server/routes/instance/httpapi/server.ts	Compose HttpApi groups with `authorizationLayer` and instance middleware.
packages/opencode/src/server/routes/instance/httpapi/config.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/file.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/mcp.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/permission.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/project.ts	Attach Authorization + source project from InstanceState context.
packages/opencode/src/server/routes/instance/httpapi/provider.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/question.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/httpapi/workspace.ts	Attach Authorization middleware at the group level.
packages/opencode/src/server/routes/instance/file.ts	Update OpenAPI schema to new ripgrep match DTO.
packages/opencode/src/plugin/codex.ts	Override GPT 5.5 limits for codex plan handling.
packages/opencode/src/lsp/server.ts	Add Razor LSP + refactor Roslyn language server install/lookup.
packages/opencode/src/lsp/language.ts	Map `.csx` extension to C# language.
packages/opencode/src/file/ripgrep.ts	Migrate ripgrep JSON parsing to Effect Schema (+ derived Zod statics).
packages/opencode/src/control-plane/adaptors/worktree.ts	Replace Zod parsing with Effect Schema decoding.
packages/opencode/src/cli/cmd/import.ts	Replace message/part Zod parsing with Effect Schema decoding.
packages/opencode/src/acp/agent.ts	Switch todowrite parsing from Zod to Effect Schema result decode.
packages/opencode/specs/effect/http-api.md	Rewrite HttpApi migration spec to current plan/status.
packages/opencode/package.json	Add `prettier` devDependency entry.
packages/guardrails/profile/plugins/team.ts	Default limit/strategy at execute time + disable recursive orchestration tools inside workers.
nix/hashes.json	Update Nix nodeModules hashes.
bun.lock	Lockfile update (prettier).
.github/VOUCHED.td	Update vouch list entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T05:02:41Z

+function group(title: string) {
+ if (process.env.GITHUB_ACTIONS !== "true") {
+ console.log(title)
+ return { [Symbol.dispose]() {} }
+ }
+ console.log(`::group::${title}`)
+ return {
+ [Symbol.dispose]() {
+ console.log("::endgroup::")
+ },


::group::... workflow commands require escaping %, \r, and \n in the message. Since title includes PR titles, an unexpected newline or % can break log grouping or inject additional workflow commands. Consider sanitizing title (e.g., replace %→%25, \r→%0D, \n→%0A) before logging it in GitHub Actions mode.

github-actions · 2026-04-25T05:04:21Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

fwangand others added 24 commits April 24, 2026 14:05

zen: gpt-5.5
d01ad4c

zen: gpt-5.5
3776d85

zen: gpt-5.5
4dab2a8

zen: gpt-5.5
0405bc7

Refactor HttpApi auth middleware wiring (anomalyco#24168)
435becb

refactor(schema): decode effect schemas directly (anomalyco#24169)
cf45a8d

chore: generate
7a02eee

Clarify HttpApi migration plan (anomalyco#24211)
361d700

ignore: denounce ai spammer
872cdff

chore: generate
c4e33d3

fix: ensure gpt-5.5 compacts at correct context size when using opena…
4a67905
…i oauth (anomalyco#24212)

refactor(ripgrep): migrate result schemas to effect (anomalyco#24213)
5a04de2

test(httpapi): cover hono bridge middleware (anomalyco#24216)
97eb9fd

chore: generate
5cd178b

Add Roslyn support for Razor and C# scripts (anomalyco#24228)
1e4b7b5

fix: validate beta before pushing (anomalyco#24230)
386091b

chore: generate
ec20162

chore: group beta PR logs (anomalyco#24236)
cdc7d5f

fix(build): add prettier to devDependencies (anomalyco#23255)
4989433

chore: update nix node_modules hashes
e29058c

ci: adjust auto close issue script to use not planned instead of comp…
f7d527c
…leted (anomalyco#24253)

Merge remote-tracking branch 'upstream/dev' into fix/team-limit-defau…
16dbda1
…lt-deadlock

fix(team): prevent default limit and worker recursion deadlocks
2904df6

CopilotAI review requested due to automatic review settings April 25, 2026 04:57

github-actionsBot added the needs:issue label Apr 25, 2026

github-actionsBot added the needs:compliance label Apr 25, 2026

Copilotstarted reviewing on behalf of terisuke April 25, 2026 04:57 View session

CopilotAI reviewed Apr 25, 2026
View reviewed changes

github-actionsBot removed needs:issue needs:compliance labels Apr 25, 2026

fix(beta): escape workflow group titles
439cde3

terisuke merged commit 2cbe327 into devApr 25, 2026
2 of 9 checks passed

terisuke deleted the fix/team-limit-default-deadlock branch April 25, 2026 05:13

terisuke mentioned this pull request Apr 29, 2026
test: upstream-sync fork hardening and local deployment E2E plan #195
Closed

Navigation Menu

Uh oh!

fix(team): prevent default limit and worker recursion deadlocks - #184

fix(team): prevent default limit and worker recursion deadlocks#184
terisuke merged 25 commits into
devfrom
fix/team-limit-default-deadlock

terisuke commented Apr 25, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAIApr 25, 2026

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

terisuke commented Apr 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAIApr 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

terisuke commented Apr 25, 2026•
edited
Loading