Skip to content

Add Mixed-auth-AllowAnonymous-workaround - #34

Open
g7ed6e wants to merge 1 commit into
CoreWCF:mainfrom
g7ed6e:feature/add-mixed-auth-allowanonymous
Open

Add Mixed-auth-AllowAnonymous-workaround#34
g7ed6e wants to merge 1 commit into
CoreWCF:mainfrom
g7ed6e:feature/add-mixed-auth-allowanonymous

Conversation

@g7ed6e

@g7ed6eg7ed6e commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@g7ed6e
g7ed6eforce-pushed the feature/add-mixed-auth-allowanonymous branch 3 times, most recently from 75415b1 to 2745dd3CompareJanuary 16, 2023 08:58
@g7ed6e
g7ed6e marked this pull request as ready for review January 16, 2023 08:59
@g7ed6e
g7ed6e requested a review from mconnewJanuary 16, 2023 08:59
@g7ed6e
g7ed6e marked this pull request as draft January 16, 2023 09:19
@g7ed6e
g7ed6eforce-pushed the feature/add-mixed-auth-allowanonymous branch from 2745dd3 to 6465d21CompareJanuary 16, 2023 09:33
@g7ed6e
g7ed6e marked this pull request as ready for review January 16, 2023 09:33
kevinchalet
kevinchalet reviewed Jan 18, 2023
View reviewed changes

@kevinchaletkevinchalet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you sent me the link via LinkedIn, I took the liberty to add a few remarks 😃

(I focused on the OpenIddict stuff and ignored the CoreWCF part as I'm not familiar at all with the stack)

Comment threadScenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs Outdated
Comment threadScenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs
Comment threadScenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs Outdated
Comment threadScenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Service/Program.cs

var builder = WebApplication.CreateBuilder();

builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)

@kevinchaletkevinchaletJan 18, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to add a note indicating that OpenIddict also has a validation handler that uses a more recent JWT stack, can easily switch to OAuth 2.0 introspection and is compatible with any standard OAuth 2.0 implementation (i.e not just OpenIddict.Server).

Comment threadScenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Service/Program.cs Outdated
@g7ed6e
g7ed6e marked this pull request as draft January 18, 2023 20:04
@g7ed6e
g7ed6eforce-pushed the feature/add-mixed-auth-allowanonymous branch from 6465d21 to a797f03CompareJanuary 18, 2023 20:21
@g7ed6e
g7ed6e marked this pull request as ready for review January 18, 2023 20:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mconnewmconnewAwaiting requested review from mconnew
1 more reviewer
@kevinchaletkevinchaletkevinchalet left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@g7ed6e@kevinchalet