fix(ci): add continue-on-error to audit job

[echobt]

Summary

The audit job is designed to track vulnerabilities via GitHub issues, not block CI. The ci-success job already excludes audit from failure checks, but the audit job itself was missing continue-on-error: true.

Changes

• Added continue-on-error: true to the audit job in CI workflow

Context

The bytes crate vulnerability (RUSTSEC-2026-0007) has been fixed in PR #14 by upgrading to bytes 1.11.1. However, the actions-rust-lang/audit@v1 action was still failing CI because it creates GitHub issues for vulnerabilities and exits with code 1 when issues exist.

Since vulnerabilities are tracked via GitHub issues rather than CI failures (as noted in the ci-success job comments), the audit job should use continue-on-error: true to match this design intent.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds continue-on-error: true to the security audit job in the CI workflow, aligning the job's behavior with the documented design intent. The change ensures that security audit failures don't block CI, as vulnerabilities are tracked through GitHub issues instead.

Key Changes

• Added continue-on-error: true to the audit job (.github/workflows/ci.yml:199)
• Added explanatory comment documenting the rationale (.github/workflows/ci.yml:198)
• Achieves consistency with the ci-success job which already excludes audit from failure checks (.github/workflows/ci.yml:228-229)

Analysis

The implementation is correct and well-aligned with the existing workflow design:

• The audit job has issues: write permissions to create GitHub issues for vulnerabilities
• The ci-success job explicitly doesn't check the audit job status and includes a comment explaining this behavior
• The actions-rust-lang/audit@v1 action exits with code 1 when vulnerabilities exist, which was blocking CI until this fix

This change completes the intended design pattern where security issues are tracked asynchronously via GitHub issues rather than blocking development workflow.

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The change is a single-line configuration addition with a clear comment that aligns the audit job behavior with the already-documented design intent in the ci-success job. The implementation is correct and completes the intended workflow pattern.
• No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/ci.yml	Added continue-on-error: true to audit job to align implementation with design intent of tracking vulnerabilities via issues rather than CI failures

Sequence Diagram

sequenceDiagram
participant GH as GitHub Workflow
participant Audit as Security Audit Job
participant Action as actions-rust-lang/audit
participant Issues as GitHub Issues
participant CI as ci-success Job
GH->>Audit: Start security audit job
Note over Audit: continue-on-error: true
Audit->>Action: Run cargo-audit
Action->>Action: Scan dependencies for vulnerabilities
alt Vulnerabilities found
Action->>Issues: Create/update GitHub issue
Action->>Audit: Exit with code 1
Note over Audit: Job marked as failed but continues
Audit->>CI: Report status (ignored)
else No vulnerabilities
Action->>Audit: Exit with code 0
Audit->>CI: Report success (ignored)
end
Note over CI: ci-success explicitly excludes audit<br/>from failure checks
CI->>CI: Check version-check, fmt, clippy, test, build-check
CI->>GH: Report final CI status

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}