feat(tui): remove toast notifications

[echobt]

Summary

This PR disables all toast notifications in the TUI application.

Changes

• Modified ToastManager methods (push, success, info, warning, error) to be no-ops (return 0 immediately)
• Commented out toast rendering in rendering.rs
• Updated toast tests to verify the new no-op behavior
• Toast module files are preserved (not deleted) for potential future re-enablement

Files Modified

• src/cortex-tui/src/widgets/toast.rs
• src/cortex-tui/src/runner/event_loop/rendering.rs
• src/cortex-tui-components/src/toast.rs

Testing

• ✅ cargo check -p cortex-tui -p cortex-tui-components passes
• ✅ Tests updated to verify no-op behavior

Note: Do NOT merge this PR - for review only.

[greptile-apps]

Greptile Overview

Greptile Summary

Disabled all toast notifications in the TUI by converting ToastManager methods to no-ops and commenting out rendering code.

Key Changes

• Modified ToastManager::push(), success(), info(), warning(), and error() to immediately return 0 without storing toasts
• Parameters are explicitly consumed with let _ = to avoid unused variable warnings
• Commented out toast rendering code in rendering.rs:122-127
• Updated all toast tests to verify the new no-op behavior (checking for empty manager and ID = 0)
• Toast infrastructure preserved for potential future re-enablement

Impact

• Toast calls throughout the codebase (in commands.rs, rendering.rs:372, modal.rs, etc.) now silently do nothing
• No visual feedback for user actions that previously showed toasts (e.g., "Copied!" message)
• Tests pass with new assertions confirming disabled behavior

Confidence Score: 5/5

• Safe to merge - clean implementation of feature disable with no logical errors
• Implementation is straightforward and safe: methods return immediately without side effects, rendering is commented out (not deleted), tests are properly updated to verify new behavior, and the pattern allows easy re-enablement
• No files require special attention

Important Files Changed

Filename	Overview
src/cortex-tui-components/src/toast.rs	Made ToastManager methods (push, success, info, warning, error) return 0 immediately without storing toasts; updated tests to verify no-op behavior
src/cortex-tui/src/widgets/toast.rs	Made ToastManager methods (push, success, info, warning, error) return 0 immediately without storing toasts; updated tests to verify no-op behavior
src/cortex-tui/src/runner/event_loop/rendering.rs	Commented out toast rendering code in the render method while keeping the logic intact

Sequence Diagram

sequenceDiagram
participant App as Application Code
participant TM as ToastManager
participant Render as Rendering Loop
participant UI as Terminal UI
Note over App,UI: Before Changes (Original Behavior)
App->>TM: success("Copied!")
TM->>TM: Assign unique ID
TM->>TM: Store toast in vector
TM-->>App: Return toast ID
Render->>TM: Check is_empty()
TM-->>Render: false (toasts exist)
Render->>UI: Render ToastWidget
UI->>UI: Display toast notification
Note over App,UI: After Changes (Disabled Behavior)
App->>TM: success("Copied!")
TM->>TM: Ignore message parameter
TM-->>App: Return 0 (no-op)
Render->>TM: Check is_empty()
TM-->>Render: true (no toasts stored)
Render->>Render: Skip toast rendering
Note over UI: No toast displayed

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}