Skip to content

Include git in images - #81

Closed
snoyberg wants to merge 1 commit into
CosmWasm:mainfrom
snoyberg-archive:include-git
Closed

snoyberg wants to merge 1 commit into
CosmWasm:mainfrom
snoyberg-archive:include-git

Conversation

@snoyberg

Copy link
Copy Markdown
Contributor

This is useful for projects which use the Cargo config:

git-fetch-with-cli = true

This can be necessary for working with some private repositories as
dependencies.

This is useful for projects which use the Cargo config:

git-fetch-with-cli = true

This can be necessary for working with some private repositories as
dependencies.
@snoyberg

Copy link
Copy Markdown
Contributor Author

Sorry, this wasn't quite ready, will open a new PR later.

@snoyberg snoyberg closed this Apr 19, 2022
@webmaster128

Copy link
Copy Markdown
Member

Diff looks plausible. Could you compare the Socker image sizes after adding git?

@adityakalia

Copy link
Copy Markdown

Without changes: 864MB (864364317KB)
With changes: 878MB (877657948KB)

@snoyberg

Copy link
Copy Markdown
Contributor Author

@webmaster128 just to clarify, @adityakalia added the functionality I'd missed first time around and reopened this as #82.

@webmaster128

Copy link
Copy Markdown
Member

@snoyberg @adityakalia thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants