Support incremental workspace optimizations - #84
Merged
Merged
Conversation
mandrean
commented
Jul 12, 2022
maurolacy
approved these changes
Jul 18, 2022
maurolacy
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Please address suggestions and we merge.
Contributor
|
Also, please add an entry in CHANGELOG.md about this change. |
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
Contributor
Author
|
@maurolacy Done & pushed! Also see my comment about the scope of |
maurolacy
reviewed
Jul 22, 2022
Contributor
Author
|
Pushed changes, have a look again @maurolacy |
Contributor
|
👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust compiler has superb support for incremental builds and other optimizations to keep down (re-)compilation times.
Unfortunately,
workspace-optimizerwill re-optimize WASM binaries even if they didn't change since the last run. In monorepos with many contracts this means a lot of pointless waiting, even on a fast machine.This PR checks the intermediate SHA against the previous one, and only re-optimizes if it changed.
Tested in a monorepo with ~10 contracts:
Update: also tested:
artifacts/, then rerun again -> re-optimizes missing binary, skips the rest