Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(ai-partner): continue-in-tab handoff from peek (#1464) by CraigBuckmaster · Pull Request #1500 · CraigBuckmaster/ScriptureDeepDive · GitHub
Skip to content

feat(ai-partner): continue-in-tab handoff from peek (#1464) - #1500

Merged
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff
Apr 17, 2026
Merged

feat(ai-partner): continue-in-tab handoff from peek (#1464)#1500
CraigBuckmaster merged 1 commit into
masterfrom
claude/issue-1464-continue-in-tab-handoff

Conversation

@CraigBuckmaster

Copy link
Copy Markdown
Owner

Summary

Resolves phase 3, card #1464 of epic #1446. Completes the FAB-peek → Amicus tab story arc.

  • New promotePeekToThread service generates a word-boundary-truncated title from the first user message, creates the thread row in amicus_threads, replays each peek message into amicus_messages (citations + follow_ups serialized), and navigates via parent.navigate('AmicusTab', { screen: 'Thread' }).
  • AmicusPeekSheet wires the CTA to the service, tracks handoffInProgress to prevent double-taps, and surfaces "Couldn't save conversation — try again" on DB failure. On failure the peek stays open so the user can retry — nothing is lost.
  • PeekMiniConversation accepts an optional handoffError string so handoff failures render cleanly without overloading the streaming-error code set.

Title generation cases:

  • < 10 chars → "New Amicus conversation" fallback
  • ≤ 50 chars → raw text
  • > 50 chars → truncated at a word boundary with trailing (hard-cut if no usable boundary)

Acceptance criteria

  • CTA appears at turn 3 (inherited from ai-partner: mini-conversation component (inside peek) #1463)
  • Tap creates thread with generated title, writes all messages
  • Navigation lands on AmicusTab/Thread with the new threadId
  • Peek closes after navigation
  • Underlying screen state preserved (standard peek-dismissal)
  • Double-tap prevented; CTA shows "Saving…" during save
  • DB failure → banner + peek stays open; messages preserved
  • Unit tests: title generation (5 cases), happy path, DB failure, missing parent nav, peek-integration (CTA/error/double-tap)
  • No any types; lint clean

Test plan

  • npx jest src/services/amicus/__tests__/promotePeekToThread.test.ts — 9 passing
  • npx jest src/components/amicus/__tests__/AmicusPeekSheet.test.tsx — 8 passing (3 new peek-integration tests)
  • Full suite: 3391 passing
  • Coverage thresholds met: 80.53 / 67.47 / 73.06 / 82.31 (vs required 80 / 65 / 72 / 82)
  • npx tsc --noEmit clean for all Amicus files
  • npx eslint clean (0 errors, 0 warnings) on changed files

https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe

Promotes an ephemeral peek conversation into a persistent Amicus
thread when the user taps "Continue in Amicus tab →".
- `promotePeekToThread` service: generates a word-boundary-truncated
title from the first user message, creates the thread row, replays
each peek message into `amicus_messages` (with citations +
follow_ups serialized), and navigates via
`getParent().navigate('AmicusTab', { screen: 'Thread' })`.
- `AmicusPeekSheet` wires the CTA to the service, tracks
`handoffInProgress` to prevent double-taps, and surfaces a
"Couldn't save conversation — try again" banner on DB failure
(peek stays open so the user can retry; messages preserved).
- `PeekMiniConversation` now accepts a `handoffError` string so
handoff failures render a clear message without reusing the
streaming-error code set.
Acceptance criteria covered:
- CTA appears at turn 3, writes thread + all messages, navigates to
AmicusTab/Thread
- Peek closes after navigation; underlying screen state preserved
- Double-tap rejected; CTA shows "Saving…" during save
- DB failure → error banner; peek stays open
https://claude.ai/code/session_01Pht3kzgdvkn81DDfL9SnFe
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed

PassedFailedTotal
Tests✅ 3391❌ 03391
Suites✅ 461❌ 0461

Coverage

StatementsBranchesFunctionsLines

⏱️ Duration: 80.9s

@CraigBuckmaster
CraigBuckmaster merged commit 11488ab into masterApr 17, 2026
6 checks passed
@CraigBuckmaster
CraigBuckmaster deleted the claude/issue-1464-continue-in-tab-handoff branch April 17, 2026 17:59
CraigBuckmaster added a commit that referenced this pull request Apr 17, 2026
…rash-I3NJC
revert: back out #1500 to unblock TestFlight launch (P0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CraigBuckmaster@claude