fix(lint): resolve 15 eslint warnings from amicus v2 merge - #1663
Merged
Conversation
Master lint CI (eslint src/ --max-warnings 0) was failing with 15 warnings introduced by the amicus v2 foundation and UI merges. ## Auto-fixable (6) Ran `eslint --fix` for import-order warnings in: - components/guidedStudy/EvidenceTrailRow.tsx - hooks/useAmicusContext.ts - services/amicus/context.ts - services/amicus/studyLaunch.ts (3 issues) ## Manual fixes (9) **screens/AmicusThreadScreen.tsx** - Removed unused `handleSend` callback — dead code superseded by `sendWithContext` which adds thread-intelligence persistence - `persistThreadIntelligence` deps: dropped redundant `linkedQuestion?.question_text` (already captured by the derived `questionText` value) and the unused `threadContext?.open_question_id` - `toggleQuestionStatus` deps: changed `thread?.chapter_ref` to `thread` to match React Compiler's inferred dep and preserve manual memoization - Auto-send effect: wrapped `sendWithContext` call in `queueMicrotask` so the setState it triggers doesn't run synchronously inside the effect body (react-hooks/set-state-in-effect) **hooks/useAmicusChapterStudyThread.ts** - Moved the `setThreadId(null)` reset into the async IIFE branch so setState isn't called synchronously in the effect body (react-hooks/set-state-in-effect) **services/amicus/__tests__/studyLaunch.test.ts** - Replaced 4 `as any` navigation stub casts with `as unknown as NavigationProp<ParamListBase>` and added the type import — silences @typescript-eslint/no-explicit-any Verified locally: eslint exits 0 on all 7 touched files.
Test Results✅ All tests passed
Coverage
⏱️ Duration: 87.5s |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master lint CI (
eslint src/ --max-warnings 0) went red after the amicus v2 foundation (#1660) and UI (#1661) merges. This PR takes it back to zero warnings.Auto-fixable (6)
Ran
eslint --fixon the files withimport/orderwarnings:components/guidedStudy/EvidenceTrailRow.tsxhooks/useAmicusContext.tsservices/amicus/context.tsservices/amicus/studyLaunch.ts(3 issues)Manual fixes (9)
screens/AmicusThreadScreen.tsxhandleSend is assigned a value but never usedsendWithContext, which adds thread-intelligence persistenceuseCallback has unnecessary dependencies: linkedQuestion.question_text and threadContext.open_question_id(onpersistThreadIntelligence)linkedQuestion?.question_textis already captured via the derivedquestionTextvalue on line 91;threadContext?.open_question_idis never referenced in the bodypreserve-manual-memoizationontoggleQuestionStatus(inferredthread, sourcethread?.chapter_ref)thread?.chapter_reftothreadto match React Compiler’s inferred depset-state-in-effectonvoid sendWithContext(initialQuery)in the auto-send effectqueueMicrotask(...)so the cascading setState insendWithContextdoesn’t run synchronously inside the effect bodyhooks/useAmicusChapterStudyThread.tsset-state-in-effectonsetThreadId(null)services/amicus/__tests__/studyLaunch.test.tsno-explicit-anyon{ getParent: () => parent } as anynavigation stubsas unknown as NavigationProp<ParamListBase>and added the type import from@react-navigation/nativeVerification
Full-repo
eslint src/timed out locally at 240s without finishing, so relying on CI for end-to-end lint verification.