feat(lenses): wire panel_filter / panel_order in ChapterScreen (#1780)

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.

[CraigBuckmaster]

Phase 1 of Epic #820 — wire panel_filter / panel_order in ChapterScreen

Closes#1780.

With Phase 0 (PR #1779) the schema, content directory, and loader for chapter_lens_content.panel_filter_json / panel_order_json shipped — but ChapterScreen.tsx consumed only lensContent.guidance, leaving the filter/order JSON columns dead. This PR makes them actually do something.

End user impact: when a chapter has lens content with a panel_filter or panel_order, activating that lens now hides non-listed panels and reorders the matching ones. The "Default" toggle restores the full view.

Utility (new)

app/src/utils/lensPanelFilter.ts — four pure functions:

Function	Behaviour
parseLensJson(json)	JSON.parse with logger.warn on failure; returns undefined for missing / malformed / non-array / non-string-array inputs
filterPanelKeys(keys, filter)	Empty filter is treated as no filter (avoids rendering zero panels from an authoring bug). Original key order preserved.
orderPanelKeys(keys, order)	Keys in order come first; keys not in order appended in original relative order; missing-from-actual-keys entries silently dropped
applyLensToKeys(keys, filter, order)	Convenience: filter then order in one pass

Tests (new)

app/__tests__/unit/lensPanelFilter.test.ts — 28 cases covering:

• parseLensJson: undefined/null/empty → undefined; valid array → strings; empty array; malformed JSON → undefined + warn; non-array JSON → undefined; non-string entries dropped + warn
• filterPanelKeys: undefined filter; empty filter (deliberate no-op); kept-keys preserve original order; missing-from-keys filter entries dropped; no-overlap → []; input not mutated
• orderPanelKeys: undefined/empty order; full reorder; partial order with appended unordered keys; missing-from-keys order entries dropped; duplicate order entries deduped; input not mutated
• applyLensToKeys: filter+order combined; only filter; only order; order keys outside filter dropped
• End-to-end: parsed JSON strings → applied; both malformed → keys unchanged

Wiring in ChapterScreen

The lens-data hooks (useAvailableLenses, useChapterLensContent) were previously fetched afteruseChapterPanels. Moved them earlier so derived filtered sections / chapterPanels can flow into the panel hook.

• lensPanelFilter / lensPanelOrder — useMemos wrapping parseLensJson
• lensIsActive — true when a lens is selected AND has filter or order data
• lensFilteredSections — useMemo. When inactive, returns sections by reference (memoised consumers don't invalidate). When active, each section gets a copy with its panels[] filtered + reordered by panel_type.
• lensFilteredChapterPanels — same treatment for the flat chapter-panels list

Downstream changes:

• useChapterPanels({ sections: lensFilteredSections, ... }) — depth-tracking and panel-open handlers see the lens view
• ChapterVerseList receives both filtered versions
• studyEstimate uses the filtered panels so the chapter's depth estimate reflects the lens-trimmed view

What's NOT changed

• useChapterTTS still receives the raw sections array — TTS reads verse text, not panels, so the lens filter has no relevance there.
• The destructured sections and chapterPanels from useChapterData remain raw. They're the source of truth; lens filtering is a presentation transform only.

Behaviour decisions (pinned in tests)

• Empty filter array → treat as "no filter". An empty array would render zero panels, which is almost certainly an authoring bug rather than intent. The schema validator already rejects empty panel_filter arrays at content time; this is the runtime safety net.
• Order keys not present in panels → silently dropped, no crash
• Panels not present in order → appended after ordered keys, preserving original relative order
• Bad JSON in either column → logger.warn once, fallback to no transformation

Out of scope

• Reordering panels within a section's individual content blocks (we operate at the panel_type key level only)
• New lens content ([#820 / 2] Pilot batch — Genesis (50 chapters) #1781 Genesis pilot delivers that)
• Animations on lens toggle (panels still appear/reorder instantly; if jank shows up in [#820 / 2] Pilot batch — Genesis (50 chapters) #1781 smoke testing we'll add LayoutAnimation in a follow-up)

Rollback plan

Pure additive refactor. The behaviour when no lens is active is byte-identical to master (verified by referential equality in the useMemo short-circuits). git revert is clean — nothing depends on these new helpers yet outside of the screen itself.

Note on bookkeeping

This issue was briefly closed on a false premise (I claimed PR #1779 contained this work; it didn't — see correction comment on #1780). Reopened, repeated, and shipping properly here.

[github-actions]

Test Results

✅ All tests passed

	Passed	Failed	Total
Tests	✅ 4001	❌ 0	4001
Suites	✅ 532	❌ 0	532

Coverage

Statements	Branches	Functions	Lines
—	—	—	—

⏱️ Duration: 97.7s

[CraigBuckmaster]

CI fix — test job failure resolved

Two lensPanelFilter.test.ts cases asserted warnSpy (jest.spyOn(console, 'warn')) was called. They passed locally but failed in CI with Received number of calls: 0.

Root cause: the project's jest setup silences/replaces console.warn globally, so a fresh spy registers zero calls regardless of whether logger.warn fires.

Fix: follow the established project pattern — mock the logger module directly. Other test files in the repo do this exact thing (e.g. useAmicusChipContext.test.tsx, ProgressRow.test.tsx, all the db/*.test.ts files).

-let warnSpy: jest.SpyInstance;-beforeEach(() => {- warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);-});+jest.mock('@/utils/logger', () => ({+ logger: { info: jest.fn(), warn: jest.fn(), error: jest.fn() },+}));+const { logger: mockLogger } = require('@/utils/logger') as { ... };+beforeEach(() => { jest.clearAllMocks(); });

Test count + behaviour pins unchanged (28 cases). a0530b8 pushed; CI re-running.