Uh oh!
There was an error while loading. Please reload this page.
chore: add .python-version to templates missing it - #154
Conversation
Only uv-workspace-starter shipped one, so entering a scaffolded project from any of the other five left pyenv and 'uv python pin' with nothing to resolve against. Add .python-version containing 3.12 to celery-worker, cli-starter, django-api, fastapi-starter and mlops-sklearn-starter. Every one of them declares requires-python = ">=3.12" (cli-starter in pyproject.toml.template), so the pin matches the manifest rather than guessing, and matches the existing uv-workspace-starter file byte for byte. ClosesCreate-Python-App#153
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe five templates now include ChangesTemplate Python Version Pinning
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thanks @dchaudhari7177 for the contribution — closing as duplicate of #159 which already covers #152 ( |
Closes#153.
Adds
.python-versionto the five templates that were missing it. Single PR covering all of them, since the change is one identical file each.Version chosen
3.12, matching each template's own manifest rather than picking a number:requires-python>=3.12pyproject.toml>=3.12pyproject.toml.template>=3.12pyproject.toml>=3.12pyproject.toml>=3.12pyproject.tomlcli-starterwas the one worth double-checking — it shipspyproject.toml.templaterather than a plainpyproject.toml, so agrep requires-python templates/*/pyproject.tomlmisses it. It declares>=3.12too.uv-workspace-starteralready had the file and is untouched.Matching the reference implementation
The new files are byte-identical to the existing
uv-workspace-starter/.python-version—3.12plus a trailing newline, LF. I checked the committed blob rather than the working copy, since git's autocrlf shows CRLF on checkout here:Verified
The audit in the issue matches what's on disk — I re-ran it before writing anything, and all five were genuinely missing.
python scripts/ci/validate-registry.pypasses:✅ registry ok (6 templates, 18 extensions).Small aside, unrelated to this change and not something I've touched: that script crashes on Windows under a non-UTF-8 locale because it prints
✅to a cp1252 stdout.PYTHONUTF8=1works around it, and CI is Linux so it's green there. Happy to send a one-line fix separately if it's worth having.Summary by CodeRabbit