Uh oh!
There was an error while loading. Please reload this page.
fix(cli): preserve trailing dir after --template file:// URL (#245) - #250
Merged
Merged
Conversation
--template file://… was incorrectly setting saw_positional, so a trailing project_directory after --addons was treated as an addon slug. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
ulises-jeremias
commented
Jul 23, 2026
MemberAuthor
Self code reviewVerdict: approve / merge Correctness
Tests
Notes (non-blocking)
CI is green including markdownlint + MegaLinter. Merging and tagging |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_expand_variadic_optionso values of--template/-t/ other value-taking flags do not setsaw_positionalproject_directoryafter--addonswhen the template is afile://(or other) URLFixes#245
Test plan
uv run pytest tests/test_cli.pyinpackages/create-awesome-python-app(19 passed)create-awesome-python-app@0.2.11when readyMade with Cursor