refactor(versioning): add ref to nodes by oreenlivnicode · Pull Request #161 · CycodeLabs/raven

oreenlivnicode · 2023-11-16T15:33:34Z

No need to review tests in this PR.
It is blocked by tests pr #160

oreenlivnicode

No need to review tests.

oreenlivnicode · 2023-11-16T16:04:35Z

Searching for a workflow by its name and processing the 'name' field from the workflow data has a lot of overhead. It loops through all the workflows in the redis every time.

method. Would it be feasible to restrict the search to just the local directory instead?
In workflow.py on line 243, there is a line of code: if "workflow_run" in w.trigger.

elad-pticha

LG! Left some comments for readability.

Support versioning in gh_api Add versioning to redis Use ref_pointers hash Index using ref_pointers Change workflow_download_hitory to consist workflow paths instead of repos

Add support for tags and refs in nodes Add commit sha resolution login to gh_api Add utils module to indexer Download and Index seems to work Not passing tests.

Unit tests passing

Calculate uses property of objects with absolute path

Add unit tests for dependency Support multiple refs for nodes. Add get_workflow and get_action. Check in index if node exists with its full name (commit_sha) Add push_graph function to neo4j_graph, which pushes and not merges. Rename push_graph to merge_graph. Update integration tests snapshots.

Document push_object and merge_object Revert tests_init.py Rename gh_api functions get_download_url_for_composite_action

Update function docs. Add utils functions

* refactor: Support versioning in gh_api Add versioning to redis Use ref_pointers hash Index using ref_pointers Change workflow_download_hitory to consist workflow paths instead of repos * Refactor + Feat: Add support for tags and refs in nodes Add commit sha resolution login to gh_api Add utils module to indexer Download and Index seems to work Not passing tests. * Tests: Unit tests passing * Refactor: Calculate uses property of objects with absolute path * Refactor + Tests: Add unit tests for dependency Support multiple refs for nodes. Add get_workflow and get_action. Check in index if node exists with its full name (commit_sha) Add push_graph function to neo4j_graph, which pushes and not merges. Rename push_graph to merge_graph. Update integration tests snapshots. * Docs + Tests: Document push_object and merge_object Revert tests_init.py Rename gh_api functions get_download_url_for_composite_action * Chore: PR tasks * Chore: Update function docs. Add utils functions

oreenlivnicode commented Nov 16, 2023
View reviewed changes

Comment threadsrc/downloader/download.py Outdated
Comment threadsrc/downloader/download.py Outdated
Comment threadsrc/workflow_components/composite_action.py Outdated
Comment threadsrc/workflow_components/workflow.py Outdated

oreenlivnicode added the blocked label Nov 16, 2023