Uh oh!
There was an error while loading. Please reload this page.
make getConfigPath a public Core API - #5823
Merged
Merged
Conversation
also export to Lua as `dfhack.getConfigPath` mainly so that we can move `dfhack-config` without having to update hundreds of source locations
plus some light code cleanup
also modernize code
ab9rf
marked this pull request as ready for review
June 6, 2026 19:45
also reorder includes om `LuaTools.h` to match our coding standards
chdoc
requested changes
Jul 10, 2026
chdoc
left a comment
Member
There was a problem hiding this comment.
This (obviously) needs a changelog entry as well as changes to the documentation of the LuaAPI. Other than that, all changes look reasonable to me, even though I do not fully understand the motivation for all of the changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* change `loadScriptPaths` to a `Core` private method * add comments to header file for `getHackPath` and `getConfigPath` regarding validity of the return values of these methods * fix include ordering in `LuaTools.h` * add/update documentation for Lua exports `getHackPath` and `getConfigPath` * add changelog
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also export to Lua as
dfhack.getConfigPathmainly so that we can move
dfhack-configwithout having to update hundreds of source locations