Skip to content

Petitions Overlay - #1528

Draft
woutersparre wants to merge 4 commits into
DFHack:masterfrom
woutersparre:master
Draft

Petitions Overlay#1528
woutersparre wants to merge 4 commits into
DFHack:masterfrom
woutersparre:master

Conversation

@woutersparre

@woutersparrewoutersparre commented Dec 17, 2025•
edited
Loading

Copy link
Copy Markdown
image

Script that add extra information about petitioners to the petitions screen

If this PR makes an externally-visible change in behavior, please add an appropriate line to changelog.txt.

@woutersparre
Petitions Overlay
eca2510
Script that add extra information about petitioners to the petitions screen
@SilasD

SilasD commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

I didn't dig into this too deeply, because I ran into the use of gps to find info about the selected petition. Probing the raw screen is not a reasonable way to discover UI state.

SilasD
SilasD reviewed Dec 17, 2025
View reviewed changes
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
Comment threadpetitioners.lua Outdated
@woutersparre

woutersparre commented Dec 18, 2025

Copy link
Copy Markdown
Author

Thats alot of useful feedback,
Thank you so much Silas I will look into all of these issues

@woutersparre
woutersparre marked this pull request as ready for review December 20, 2025 09:57
@woutersparre
woutersparre marked this pull request as draft December 20, 2025 12:28
@woutersparre

woutersparre commented Mar 5, 2026

Copy link
Copy Markdown
Author

Hi!
I’ve made some changes a while back based on SilasD’s helpful feedback.
If anyone has time to take another look, I’d really appreciate any additional feedback. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SilasDSilasDSilasD left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@woutersparre@SilasD