Skip to content

fix for modtools/create-unit - #1530

Open
dvantwisk wants to merge 5 commits into
DFHack:masterfrom
dvantwisk:create-unit-fix
Open

fix for modtools/create-unit#1530
dvantwisk wants to merge 5 commits into
DFHack:masterfrom
dvantwisk:create-unit-fix

Conversation

@dvantwisk

@dvantwiskdvantwisk commented Jan 3, 2026

Copy link
Copy Markdown

This fix changes the "arena spawn" paradigm that no longer works with the new version of DF to use dfhack.units.create(). It guts most arena-specific code, changes the method in which skills and equipment are applied, updates unit block info, and teleports the unit to the specified location. There's likely more to do, but for now this seems to revive the script's functionality as it was before the steam version of DF.

@ab9rfab9rf moved this from Todo to Review In Progress in 53.09-r2Jan 8, 2026
@ab9rfab9rf removed this from 53.09-r2Jan 12, 2026
@ab9rfab9rf moved this from Todo to Review In Progress in 53.10-r2Jan 12, 2026

@ab9rfab9rf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but needs a changelog entry

@ab9rfab9rf moved this from Review In Progress to Being worked on in 53.10-r2Feb 9, 2026
@ab9rfab9rf moved this from Being worked on to Needs revision in 53.10-r2Feb 16, 2026
@github-project-automationgithub-project-automationBot moved this from Needs review to Needs revision in AFTER NEXTFeb 27, 2026
@github-project-automationgithub-project-automationBot moved this to Needs review in AFTER NEXTFeb 27, 2026
@ab9rfab9rf removed this from 53.10-r2Feb 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs revision

Development

Successfully merging this pull request may close these issues.

2 participants

@dvantwisk@ab9rf