Uh oh!
There was an error while loading. Please reload this page.
docs(spec): correct the dig-node-core P2P dependency list to match Cargo.toml - #132
Merged
Conversation
…rgo.toml SPEC.md §1.1 listed `dig-protocol` among dig-node-core's direct P2P dependencies, but that crate is not a dependency: it was renamed to `dig-peer-protocol` (#1383) and is not a direct dep of dig-node-core (it only gates dig-gossip's crates.io publish, #681). The blanket "as git dependencies" phrasing was also imprecise — the P2P crates are consumed from crates.io (§3.6) except `dig-gossip`, which stays a pinned git dependency until its publish is unblocked; only the digstore store- format crates are git deps. Corrected to match the actual `crates/dig-node-core/ Cargo.toml` (dig-nat/dig-dht/dig-pex/dig-download/dig-peer-selector = crates.io, dig-gossip = git rev, digstore-* = git). Docs only, no code change. Closes #1455 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1455.
Problem
SPEC.md§1.1 listeddig-protocolamong dig-node-core's direct P2P dependencies and described the deps as consumed "as git dependencies." Verified against the currentcrates/dig-node-core/Cargo.toml, both are inaccurate:dig-protocolis not a dependency. It was renamed todig-peer-protocol(#1383) and is not a direct dep of dig-node-core — it only gatesdig-gossip's crates.io publish (#681).dig-nat0.15,dig-dht0.9,dig-pex0.1,dig-download0.13,dig-peer-selector0.8), with the single exception ofdig-gossip(a pinned git rev until its publish is unblocked). Only thedigstore-*store-format crates are git deps.Fix
Corrected the SPEC list to drop the phantom
dig-protocoland state the real dependency sources (crates.io for the P2P crates except dig-gossip; git for dig-gossip + digstore-*), matching Cargo.toml exactly. Docs only — no code change.Version
0.72.3→0.72.4(patch —docs:), re-locked.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Generated by Claude Code