Uh oh!
There was an error while loading. Please reload this page.
fix(download): apply the self-exclusion to the forwarded ask, and observe the A->B->C round trip - #266
Closed
MichaelTaylor3d wants to merge 2 commits into
Closed
fix(download): apply the self-exclusion to the forwarded ask, and observe the A->B->C round trip#266MichaelTaylor3d wants to merge 2 commits into
MichaelTaylor3d wants to merge 2 commits into
Conversation
…ix (#261) Refs DIG-Network/dig_ecosystem#3128 Co-Authored-By: Claude <noreply@anthropic.com>
… ask `SPEC.md` §19.3 states without qualification that NO source — DHT or pool — can ever offer self. The DHT leg honoured it twice over (a `SelfExcludingLocator` wrapper AND a second hand-written filter inside `NodeContent::find_providers`); the FORWARDED leg added by #258 honoured it not at all, so a peer's answer naming this node reached the merged provider set and cost the requestor a self-dial. The rule now has ONE implementation — `retain_excluding_self` — and it is applied at the MERGE point in `locate_holders`, which is where it covers every source the answer draws from rather than only the ones a reader thought to wrap. The two prior copies now call it. Closes#261 Refs DIG-Network/dig_ecosystem#3128 Co-Authored-By: Claude <noreply@anthropic.com>
MichaelTaylor3dforce-pushed
the
loop/3128-recursive-discovery
branch
from
August 20, 2026 15:23
9e61da5 to
9504b24CompareMichaelTaylor3d
commented
Aug 21, 2026
ContributorAuthor
Superseded by #289, which consolidated the recursive ask onto `dig_sex::discovery`. Both halves of this branch were accounted for rather than discarded:
Nothing from this branch was lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE — draft, gate round not yet run.
What
Fixes#261 — the forwarded half of
NodeContent::locate_holdersdoes not apply the self-exclusion the SPEC states withoutqualification, and adds the observed A->B->C round trip for
https://github.com/DIG-Network/dig_ecosystem/issues/3128.
Work in progress.